From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bandan Das Subject: Re: [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect Date: Thu, 21 Jul 2016 15:21:13 -0400 Message-ID: References: <1469053536-11130-1-git-send-email-bsd@redhat.com> <1469053536-11130-4-git-send-email-bsd@redhat.com> <077ad26d-e12e-f8c6-012b-4a1e50d9888a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, linux-kernel@vger.kernel.org To: Paolo Bonzini Return-path: In-Reply-To: <077ad26d-e12e-f8c6-012b-4a1e50d9888a@redhat.com> (Paolo Bonzini's message of "Thu, 21 Jul 2016 11:15:19 +0200") Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Paolo Bonzini writes: > On 21/07/2016 00:25, Bandan Das wrote: >> That parameter isn't used in the function, >> it's probably a historical artifact. > > Same for spte_clear_dirty and spte_set_dirty, please. Sure! I will fix this in a follow-up. Bandan > Paolo > >> Signed-off-by: Bandan Das >> --- >> arch/x86/kvm/mmu.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c >> index def97b3..aaecd10 100644 >> --- a/arch/x86/kvm/mmu.c >> +++ b/arch/x86/kvm/mmu.c >> @@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep) >> * >> * Return true if tlb need be flushed. >> */ >> -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect) >> +static bool spte_write_protect(u64 *sptep, bool pt_protect) >> { >> u64 spte = *sptep; >> >> @@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm, >> bool flush = false; >> >> for_each_rmap_spte(rmap_head, &iter, sptep) >> - flush |= spte_write_protect(kvm, sptep, pt_protect); >> + flush |= spte_write_protect(sptep, pt_protect); >> >> return flush; >> } >>