From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bandan Das Subject: Re: [RFC 07/55] KVM: arm/arm64: Add virtual EL2 state emulation framework Date: Fri, 02 Jun 2017 19:49:23 -0400 Message-ID: References: <1483943091-1364-1-git-send-email-jintack@cs.columbia.edu> <1483943091-1364-8-git-send-email-jintack@cs.columbia.edu> <20170602115140.GB397@cbox> <20170602190622.GF397@cbox> <20170602194353.GG397@cbox> <20170602211506.GA7654@cbox> Mime-Version: 1.0 Content-Type: text/plain Cc: kvm@vger.kernel.org To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53498 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdFBXtY (ORCPT ); Fri, 2 Jun 2017 19:49:24 -0400 In-Reply-To: <20170602211506.GA7654@cbox> (Christoffer Dall's message of "Fri, 2 Jun 2017 23:15:06 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Christoffer Dall writes: ... >> >> I started discussing with Jintack and reviewing this series so that I can understand >> it better. If I have to constantly think that with every sentence I write I am judging >> someone's abilities, or that I have to follow someone's rulebook for constructive comments, >> well, thanks and good luck! > > What can I say. I of course don't have a rulebook. I did not find your > tone friendly or the review particularly helpful, but I'll try to be > more patient next time. While I don't agree with what you are saying above, I appreciate that you will try to be patient. Not every review can be outright helpful, sometimes they are just pointers to something the reviewer prefers/likes and it's ok to ignore them. The best thing to do with an unhelpful review is to just set it aside. I didn't start out reviewing by thinking that I will pull out all tiny places where words are misspelled or structures have a typedef. I noticed the typedef usage while replying to you and thought of mentioning it. It's right there in the same patch, not across different patches and I probably would have posted a patch myself. Anyway, I will make another attempt based on your input that we should focus on the design aspect. Thanks, Bandan > -Christoffer