Re: [PATCH] x86-run: Print a meaningful message if the qemu binary isn't found

[Bandan Das <bsd@redhat.com>]

Paolo Bonzini <pbonzini@redhat.com> writes:
...
> This breaks "QEMU=... ./x86-run ./x86/msr.flat"
>
> Fixed as follows:
>
> diff --git a/x86/run b/x86/run
> index d5adf8d..219a93b 100755
> --- a/x86/run
> +++ b/x86/run
> @@ -20,16 +20,15 @@ else
>  		    break
>  		fi
>  	done
> -fi
> -
> -if      [ -z "${QEMUFOUND}" ]
> -then
> -	echo "A QEMU binary was not found, You can set a custom location by using the QEMU=<path> environment variable "
> -	exit ${NOTFOUND}
> -elif    [ -z "${qemu}" ]
> -then
> -	echo "No Qemu test device support found"
> -	exit ${TESTDEVNOTSUPP}
> +	if      [ -z "${QEMUFOUND}" ]
> +	then
> +		echo "A QEMU binary was not found, You can set a custom location by using the QEMU=<path> environment variable "
> +		exit ${NOTFOUND}
> +	elif    [ -z "${qemu}" ]
> +	then
> +		echo "No Qemu test device support found"

I think we still want to print this if the user supplied qemu has no test
device support. I think this is better -
--- a/x86/run
+++ b/x86/run
@@ -8,6 +8,7 @@ qemusystem="${QEMU:-qemu-system-x86_64}"
 if      ! [ -z "${QEMU}" ]
 then
        qemu="${QEMU}"
+       QEMUFOUND=1
 else
        for qemucmds in ${qemukvm} ${qemusystem}
        do

> +		exit ${TESTDEVNOTSUPP}
> +	fi
>  fi
>  
>  if
>
> which apart from reindentation is just moving a "fi" down.
> Paolo