From: ebiederm@xmission.com (Eric W. Biederman)
To: Ingo Molnar <mingo@elte.hu>
Cc: Avi Kivity <avi@qumranet.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts
Date: Mon, 25 Aug 2008 06:14:35 -0700 [thread overview]
Message-ID: <m1vdxpnsn8.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <20080825091508.GC9114@elte.hu> (Ingo Molnar's message of "Mon, 25 Aug 2008 11:15:08 +0200")
Ingo Molnar <mingo@elte.hu> writes:
> * Avi Kivity <avi@qumranet.com> wrote:
>
>> Enabling Intel VT has the curious side effect whereby the INIT signal
>> is blocked. Rather than comment on the wisdom of this side effect,
>> this patch adds an emergency restart reboot notifier, and modifies the
>> kvm reboot notifier to disable VT on emergency reboot.
Please no notifiers in emergency_restart.
First emergency_restart is not supposed to work reliably it is a best effort tickle
the hardware thing.
Second and more importantly whenever someone adds a notifier instead of a proper hook
to one a code path like this it seems like avoiding building a proper interface so
and I believe keeps us from getting all of the logic and the heuristics right.
Why not just add a disable intel_vt if it is enabled call?
Eric
prev parent reply other threads:[~2008-08-25 13:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 9:11 [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts Avi Kivity
2008-08-25 9:15 ` Ingo Molnar
2008-08-25 9:27 ` Avi Kivity
2008-08-25 9:30 ` Ingo Molnar
2008-08-25 10:03 ` Avi Kivity
2008-08-25 10:27 ` Ingo Molnar
2008-08-25 10:36 ` Avi Kivity
2008-08-25 13:12 ` Eric W. Biederman
2008-08-25 13:35 ` Avi Kivity
2008-08-25 13:14 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1vdxpnsn8.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox