From: Andreas Schwab <schwab@linux-m68k.org>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, kvm list <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH 2/3] KVM: PPC: Add support for explicit HIOR setting
Date: Sun, 01 Apr 2012 21:51:42 +0200 [thread overview]
Message-ID: <m2vcljjkmp.fsf@linux-m68k.org> (raw)
In-Reply-To: <1325822371-11721-3-git-send-email-agraf@suse.de> (Alexander Graf's message of "Fri, 6 Jan 2012 04:59:30 +0100")
Alexander Graf <agraf@suse.de> writes:
> @@ -662,6 +668,13 @@ static int kvm_vcpu_ioctl_set_one_reg(struct kvm_vcpu *vcpu,
> int r = -EINVAL;
>
> switch (reg->id) {
> +#ifdef CONFIG_PPC_BOOK3S
> + case KVM_ONE_REG_PPC_HIOR:
> + r = get_user(to_book3s(vcpu)->hior, (u64 __user *)reg->addr);
That doesn't build on ppc32, get_user cannot handle 64 bit values. You
need to use __get_user64 instead.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-04-01 19:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 3:59 [PATCH 0/3] GET/SET_ONE_REG and HIOR patches v2 Alexander Graf
2012-01-06 3:59 ` [PATCH 1/3] KVM: PPC: Add generic single register ioctls Alexander Graf
2012-01-06 3:49 ` Alexander Graf
2012-01-06 4:15 ` [PATCH] " Alexander Graf
2012-01-06 19:32 ` Scott Wood
2012-01-07 0:52 ` Alexander Graf
2012-01-09 19:07 ` Scott Wood
2012-01-09 20:11 ` Alexander Graf
2012-01-09 20:12 ` Scott Wood
2012-01-09 20:14 ` Alexander Graf
2012-01-06 3:59 ` [PATCH 2/3] KVM: PPC: Add support for explicit HIOR setting Alexander Graf
2012-01-06 18:42 ` Scott Wood
2012-04-01 19:51 ` Andreas Schwab [this message]
2012-04-16 16:54 ` Alexander Graf
2012-04-16 21:42 ` Paul Mackerras
2012-01-06 3:59 ` [PATCH 3/3] KVM: PPC: Move kvm_vcpu_ioctl_[gs]et_one_reg down to platform-specific code Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vcljjkmp.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox