From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH 2/3] KVM: PPC: Add support for explicit HIOR setting
Date: Sun, 01 Apr 2012 21:51:42 +0200
Message-ID: <m2vcljjkmp.fsf@linux-m68k.org>
References: <1325822371-11721-1-git-send-email-agraf@suse.de>
	<1325822371-11721-3-git-send-email-agraf@suse.de>
Mime-Version: 1.0
Content-Type: text/plain
Cc: kvm-ppc@vger.kernel.org, kvm list <kvm@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <1325822371-11721-3-git-send-email-agraf@suse.de> (Alexander
	Graf's message of "Fri, 6 Jan 2012 04:59:30 +0100")
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Alexander Graf <agraf@suse.de> writes:

> @@ -662,6 +668,13 @@ static int kvm_vcpu_ioctl_set_one_reg(struct kvm_vcpu *vcpu,
>  	int r = -EINVAL;
>  
>  	switch (reg->id) {
> +#ifdef CONFIG_PPC_BOOK3S
> +	case KVM_ONE_REG_PPC_HIOR:
> +		r = get_user(to_book3s(vcpu)->hior, (u64 __user *)reg->addr);

That doesn't build on ppc32, get_user cannot handle 64 bit values.  You
need to use __get_user64 instead.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."