From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] Avoid Wunsed-but-set warnings (or errors in case of Werror)
Date: Tue, 05 Jul 2011 09:49:56 +0200
Message-ID: <m34o31b1zv.fsf@blackfin.pond.sub.org>
References: <cover.1309816302.git.rprabhu@wnohang.net>
	<2cb2082c25eadc24d1e22ebbd4293e3e6b53c832.1309816302.git.rprabhu@wnohang.net>
	<m3oc19b6ct.fsf@blackfin.pond.sub.org>
	<CAFEAcA-sdv2W_xQcGtKw5Lvkndpve_yTLsV=vMuwFVpFLM-e3w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Raghavendra D Prabhu <rprabhu@wnohang.net>, qemu-devel@nongnu.org,
	Raghavendra D Prabhu <raghu.prabhu13@gmail.com>,
	kvm@vger.kernel.org
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:6699 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753879Ab1GEHuE convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Tue, 5 Jul 2011 03:50:04 -0400
In-Reply-To: <CAFEAcA-sdv2W_xQcGtKw5Lvkndpve_yTLsV=vMuwFVpFLM-e3w@mail.gmail.com>
	(Peter Maydell's message of "Tue, 5 Jul 2011 08:02:36 +0100")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 5 July 2011 07:15, Markus Armbruster <armbru@redhat.com> wrote:
>>> + =C2=A0 =C2=A0int fd, __attribute__((unused)) ret;
>>>
>>> =C2=A0 =C2=A0 =C2=A0snprintf(reset_file, sizeof(reset_file),
>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "/sys/bus/pci/devi=
ces/%04x:%02x:%02x.%01x/reset",
>>
>> What about (void)write() and do away with ret?
>
> If 'ret' has been used to silence compiler warnings about functions
> which have been declared with attribute __warn_unused_result__
> (eg write() and various other libc functions) then "(void)write()"
> is insufficient -- gcc requires the variable.

gcc being silly.  Oh well.