From: Markus Armbruster <armbru@redhat.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, aliguori@us.ibm.com, kvm@vger.kernel.org,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V4 3/3] qmp, nmi: convert do_inject_nmi() to QObject, QError
Date: Mon, 20 Dec 2010 18:01:34 +0100 [thread overview]
Message-ID: <m34oa82xap.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <4D0EF3A4.7000303@cn.fujitsu.com> (Lai Jiangshan's message of "Mon, 20 Dec 2010 14:11:48 +0800")
Lai Jiangshan <laijs@cn.fujitsu.com> writes:
> Make we can inject NMI via qemu-monitor-protocol.
> We use "inject-nmi" for the qmp command name, the meaning is clearer.
> When cpu-index is found invalid in runtime, it will report
> QERR_INVALID_PARAMETER_VALUE.
This patch does two separate things:
1. Fix do_inject_nmi() to detect invalid arguments.
2. Convert it to QObject.
If you have to respin anyway, please split the patch to keep the two
separate.
prev parent reply other threads:[~2010-12-20 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 6:11 [PATCH V4 3/3] qmp,nmi: convert do_inject_nmi() to QObject, QError Lai Jiangshan
2010-12-20 17:01 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34oa82xap.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox