From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V4 3/3] qmp, nmi: convert do_inject_nmi() to QObject, QError
Date: Mon, 20 Dec 2010 18:01:34 +0100
Message-ID: <m34oa82xap.fsf@blackfin.pond.sub.org>
References: <4D0EF3A4.7000303@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org,
	aliguori@us.ibm.com, kvm@vger.kernel.org,
	Avi Kivity <avi@redhat.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:28301 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932888Ab0LTRBk (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 20 Dec 2010 12:01:40 -0500
In-Reply-To: <4D0EF3A4.7000303@cn.fujitsu.com> (Lai Jiangshan's message of
	"Mon, 20 Dec 2010 14:11:48 +0800")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Lai Jiangshan <laijs@cn.fujitsu.com> writes:

> Make we can inject NMI via qemu-monitor-protocol.
> We use "inject-nmi" for the qmp command name, the meaning is clearer.
> When cpu-index is found invalid in runtime, it will report
> QERR_INVALID_PARAMETER_VALUE.

This patch does two separate things:

1. Fix do_inject_nmi() to detect invalid arguments.

2. Convert it to QObject.

If you have to respin anyway, please split the patch to keep the two
separate.