From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [PATCH] qemu-kvm: Switch to upstream -enable-kvm semantics Date: Tue, 21 Dec 2010 16:41:03 +0100 Message-ID: References: <4D08FB7D.2010702@codemonkey.ws> <4D10C4B2.9000401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , kvm@vger.kernel.org, "Daniel P. Berrange" , "Richard W. M. Jones" , qemu-devel To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3739 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943Ab0LUPlI (ORCPT ); Tue, 21 Dec 2010 10:41:08 -0500 In-Reply-To: <4D10C4B2.9000401@redhat.com> (Avi Kivity's message of "Tue, 21 Dec 2010 17:16:02 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity writes: > On 12/15/2010 07:57 PM, Markus Armbruster wrote: >> > In the short term, it would be a good idea to modify qemu-kvm to >> > switch the -enable-kvm semantics to match upstream (fail if KVM isn't >> > available). >> >> That's what my patch does. >> >> Additionally, it changes the default to match upstream: KVM disabled. >> >> What do you want changed in my patch? > > The 'Additionally' bit. qemu-kvm users rely on the default enabling > kvm. Likely they don't rely on -enable-kvm failing is kvm is not > available (and indeed, they likely expect it to match upstream). So > the patch should only change behaviour when -enable-kvm is specified. Like this? upstream qemu | default |-enable-kvm ----------------+-----------+----------- KVM available | disabled | enabled KVM unavailable | disabled | fail qemu-kvm | default |-enable-kvm| -no-kvm ----------------+-----------+-----------+----------- KVM available | enabled* | enabled | disabled KVM unavailable | disabled | fail | disabled * differs from upstream