From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [PATCH 2/2 V7] qemu, qmp: add inject-nmi qmp command Date: Thu, 14 Apr 2011 08:41:44 +0200 Message-ID: References: <4D9CAAF9.7000509@codemonkey.ws> <20110406150818.56707b9b@doriath> <4D9CAE4B.7080305@siemens.com> <20110406160020.373cb5a2@doriath> <4D9CC044.2000705@codemonkey.ws> <4D9E0352.2050204@codemonkey.ws> <20110407185108.GE7100@redhat.com> <20110407191759.GG7100@redhat.com> <4D9E2F6F.3040008@codemonkey.ws> <4DA16FCB.7040509@redhat.com> <4DA404A4.3030308@redhat.com> <20110413100829.55bc4a33@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Peter Maydell , Lai Jiangshan , Jiangshan , Gleb Natapov , Jan Kiszka , qemu-devel@nongnu.org, Luiz Capitulino , Avi Kivity , kvm@vger.kernel.org To: Blue Swirl Return-path: In-Reply-To: (Blue Swirl's message of "Wed, 13 Apr 2011 22:56:21 +0300") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Blue Swirl writes: > On Wed, Apr 13, 2011 at 4:08 PM, Luiz Capitulino = wrote: >> On Tue, 12 Apr 2011 21:31:18 +0300 >> Blue Swirl wrote: >> >>> On Tue, Apr 12, 2011 at 10:52 AM, Avi Kivity wrote: >>> > On 04/11/2011 08:15 PM, Blue Swirl wrote: >>> >> >>> >> On Mon, Apr 11, 2011 at 10:01 AM, Markus Armbruster >>> >> =C2=A0wrote: >>> >> > =C2=A0Avi Kivity =C2=A0writes: >>> >> > >>> >> >> =C2=A0On 04/08/2011 12:41 AM, Anthony Liguori wrote: >>> >> >>> >>> >> >>> =C2=A0And it's a good thing to have, but exposing this as the on= ly API to >>> >> >>> =C2=A0do something as simple as generating a guest crash dump is= not the >>> >> >>> =C2=A0friendliest thing in the world to do to users. >>> >> >> >>> >> >> =C2=A0nmi is a fine name for something that corresponds to a real= -life nmi >>> >> >> =C2=A0button (often labeled "NMI"). >>> >> > >>> >> > =C2=A0Agree. >>> >> >>> >> We could also introduce an alias mechanism for user friendly names, = so >>> >> nmi could be used in addition of full path. Aliases could be useful >>> >> for device paths as well. >>> > >>> > Yes. =C2=A0Perhaps limited to the human monitor. >>> >>> I'd limit all debugging commands (including NMI) to the human monitor. >> >> Why? > > Do they have any real use in production environment? Also, we should > have the freedom to change the debugging facilities (for example, to > improve some internal implementation) as we want without regard to > compatibility to previous versions. For what it's worth, Lai (original poster) has been trying for many months to get inject-nmi into QMP, and I suspect he has a really good reason for his super-human persistence.