Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size

[Juan Quintela <quintela@redhat.com>]

Avi Kivity <avi@redhat.com> wrote:
> On 05/26/2010 03:27 AM, Juan Quintela wrote:
>> Alex Williamson<alex.williamson@redhat.com>  wrote:
>>    
>>> PCI_MSIX_TABSIZE is 0x07ff
>>>
>>> Reported-by: Juan Quintela<quintela@redhat.com>
>>> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
>>>      
>> Acked-by: Juan Quintela<quintela@redhat.com>
>>
>> BTW, I also noticed the lack of pci_set_long() and friend functions, but
>> arrived to the same conclusion that you: all the device assignment
>> assumes that the world is x86_64 :)
>>    
>
> IIRC it used to work on ia64 as well.

But ia64 is little endian :)

static inline void
pci_set_word(uint8_t *config, uint16_t val)
{
    cpu_to_le16wu((uint16_t *)config, val);
}

on little endian, this is always an assignment :)

Problem is if we have big endian somewhere in the middle.

Later, Juan.