From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] device-assignment: don't truncate MSIX capabilities table size
Date: Wed, 26 May 2010 14:54:28 +0200
Message-ID: <m38w76ddrv.fsf@trasno.mitica>
References: <20100525230131.6313.27447.stgit@localhost.localdomain>
	<m3fx1fecdn.fsf@trasno.mitica> <4BFD189B.3050603@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alex Williamson <alex.williamson@redhat.com>, kvm@vger.kernel.org,
	chrisw@redhat.com
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:40771 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753119Ab0EZMyb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 26 May 2010 08:54:31 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4QCsUsR009316
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Wed, 26 May 2010 08:54:31 -0400
In-Reply-To: <4BFD189B.3050603@redhat.com> (Avi Kivity's message of "Wed, 26
	May 2010 15:48:27 +0300")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity <avi@redhat.com> wrote:
> On 05/26/2010 03:27 AM, Juan Quintela wrote:
>> Alex Williamson<alex.williamson@redhat.com>  wrote:
>>    
>>> PCI_MSIX_TABSIZE is 0x07ff
>>>
>>> Reported-by: Juan Quintela<quintela@redhat.com>
>>> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
>>>      
>> Acked-by: Juan Quintela<quintela@redhat.com>
>>
>> BTW, I also noticed the lack of pci_set_long() and friend functions, but
>> arrived to the same conclusion that you: all the device assignment
>> assumes that the world is x86_64 :)
>>    
>
> IIRC it used to work on ia64 as well.

But ia64 is little endian :)

static inline void
pci_set_word(uint8_t *config, uint16_t val)
{
    cpu_to_le16wu((uint16_t *)config, val);
}

on little endian, this is always an assignment :)

Problem is if we have big endian somewhere in the middle.

Later, Juan.