From: Juan Quintela <quintela@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/1] Fix unable to detect libpci
Date: Fri, 13 Nov 2009 12:04:12 +0100 [thread overview]
Message-ID: <m3aayq8z4j.fsf@neno.mitica> (raw)
In-Reply-To: <1258093354-5048-1-git-send-email-sheng@linux.intel.com> (Sheng Yang's message of "Fri, 13 Nov 2009 14:22:34 +0800")
Sheng Yang <sheng@linux.intel.com> wrote:
> commit 75fe7882 "Test for libpci, not only for header" compile a libpci
> test file. But the pciutils with defined PCI_COMPRESSED_IDS also need zlib
> when compile, otherwise the compile would fail, and detection fail then
>
> CC: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
configure already requires -lz sooner, i.e. nothing new, and everything
execpt *-user links with -lz already.
Later, Juan.
> ---
> configure | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 9d3b840..5b08367 100755
> --- a/configure
> +++ b/configure
> @@ -1477,8 +1477,8 @@ if test $kvm_cap_device_assignment = "yes" ; then
> #endif
> int main(void) { struct pci_access a; pci_init(&a); return 0; }
> EOF
> - if compile_prog "" "-lpci" ; then
> - libs_softmmu="-lpci $libs_softmmu"
> + if compile_prog "" "-lpci -lz" ; then
> + libs_softmmu="-lpci -lz $libs_softmmu"
> else
> echo
> echo "Error: libpci check failed"
next prev parent reply other threads:[~2009-11-13 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 6:22 [PATCH 1/1] Fix unable to detect libpci Sheng Yang
2009-11-13 11:04 ` Juan Quintela [this message]
2009-11-15 12:57 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aayq8z4j.fsf@neno.mitica \
--to=quintela@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox