From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: [PATCH V6 1/4 resend] nmi: convert cpu_index to cpu-index Date: Thu, 24 Feb 2011 08:49:46 +0100 Message-ID: References: <4D58FF49.5090503@cn.fujitsu.com> <4D61C1F5.4080801@cn.fujitsu.com> <20110223155651.1d09e3f4@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Lai Jiangshan , aliguori@us.ibm.com, Jiangshan , Lai@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, Avi Kivity To: Luiz Capitulino Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37991 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754263Ab1BXHuX (ORCPT ); Thu, 24 Feb 2011 02:50:23 -0500 In-Reply-To: <20110223155651.1d09e3f4@doriath> (Luiz Capitulino's message of "Wed, 23 Feb 2011 15:56:51 -0300") Sender: kvm-owner@vger.kernel.org List-ID: Luiz Capitulino writes: > On Mon, 21 Feb 2011 09:37:57 +0800 > Lai Jiangshan wrote: > >> Hi, Luiz Capitulino >> >> Any problem? > > Sorry for the delay. Looks good in general to me know, there's only one > small problem and it's the error message: > > (qemu) nmi 100 > Parameter 'cpu-index' expects a CPU number > (qemu) > > I would expect that kind of error message when no CPU number is > provided, but in the case above the CPU number is provided but it > happens to be invalid. Why? This is not Lai Jiangshan's fault. It's what QERR_INVALID_PARAMETER_VALUE reports. The current design of QError makes it hard to do better. "expects a valid CPU number" could be done, if you think that's better. > By the way, please add an introductory email with proper changelog > when submitting series/patches, so that it's easier to review. Also make sure the parts are threaded together properly with In-Reply-To and References headers, because that helps e-mail readers to keep the parts together. Lack of threading is annoying, and annoying reviewers intentionally would be rude :) Suggested workflow: git-format-patch --cover-letter -ns ... look over patch files, edit the cover letter to taste git-send-email --to qemu-devel@nongnu.org 0*.patch