From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [PATCH v2] device-assignment: Properly terminate vmsd.fields Date: Wed, 19 Jan 2011 16:40:55 +0100 Message-ID: References: <20110117171218.29227.19416.stgit@s20.home> Reply-To: quintela@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, mst@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47745 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209Ab1ASPmD (ORCPT ); Wed, 19 Jan 2011 10:42:03 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0JFg3sv021841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Jan 2011 10:42:03 -0500 In-Reply-To: <20110117171218.29227.19416.stgit@s20.home> (Alex Williamson's message of "Mon, 17 Jan 2011 10:17:49 -0700") Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > The vmsd code expects the fields structure to be properly terminated, > not NULL. An assigned device should never be saved or restored, and > recent qemu fixes to the no_migrate flag should ensure this, but let's > avoid setting the wrong precedent. > > Signed-off-by: Alex Williamson Acked-by: Juan Quintela