From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [PATCH 04/24] piix4_dev is not used for pc's Date: Mon, 21 Sep 2009 11:37:48 +0200 Message-ID: References: <20090918190541.GB14562@amt.cnet> <4AB74316.6060107@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32964 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755842AbZIUJiD (ORCPT ); Mon, 21 Sep 2009 05:38:03 -0400 In-Reply-To: <4AB74316.6060107@redhat.com> (Avi Kivity's message of "Mon, 21 Sep 2009 12:10:46 +0300") Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > On 09/19/2009 12:42 AM, Juan Quintela wrote: >> >>> Not applying because its dead code with the current state of pc.c >>> configuration but this prevents one to use piix4. >>> >> piix4 is not used for pci irq assignement in pc. It is only used on >> mips. I am the one that split the file in qemu upstream. piix4 and >> piix3 are the same from the irq point of view. >> >> next pc chipset is not going to be piix4 :) >> > > I agree with Marcelo - even if mips never gains device assignment or > pc never uses piix4, the code is more complete the way it is. Ok, it forces to compile back piix4.o in a pc. In qemu upstream piix4.o is only compiled for MIPS. That is the reason why I noticed. (Yes, I am the one that did the split). Later, Juan.