Re: [Qemu-devel] Re: KVM call agenda for July 27

[Markus Armbruster <armbru@redhat.com>]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 28.07.2010 13:22, schrieb Markus Armbruster:
>> Anthony Liguori <anthony@codemonkey.ws> writes:
>> 
>>> On 07/27/2010 10:22 AM, Markus Armbruster wrote:
[...]
>>>> Raw can't be probed safely, by its very nature.  For historical reasons,
>>>> we try anyway.  I think we should stop doing that, even though that
>>>> breaks existing use relying on the misfeature.  Announce it now, spit
>>>> out scary warnings, kill it for good 1-2 releases later.
>>>>
>>>> If we're unwilling to do that, then I'd *strongly* prefer doing nothing
>>>> over silently messing with the raw writes to sector 0 (so does
>>>> Christoph, and he explained why).
>>>
>>> If we add docs/deprecated-features.txt, schedule removal for at least
>>> 1 year in the future, and put a warning in the code that prints
>>> whenever raw is probed, I think I could warm up to this.
>>>
>>> Since libvirt should be insulating users from this today, I think the
>>> fall out might not be terrible.
>> 
>> Okay, I'll prepare a patch.
>
> This kills -hda and friends for raw images. I'm not sure this is a good
> idea.

Please wait and see my patch.