From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status Date: Wed, 16 Jun 2010 20:43:51 +0200 Message-ID: References: <20100614202803.5259.85808.stgit@localhost.localdomain> <4C1697F3.3090107@codemonkey.ws> <1276705730.12015.964.camel@x201> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , qemu-devel@nongnu.org, blauwirbel@gmail.com, kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29814 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759363Ab0FPSn6 (ORCPT ); Wed, 16 Jun 2010 14:43:58 -0400 In-Reply-To: <1276705730.12015.964.camel@x201> (Alex Williamson's message of "Wed, 16 Jun 2010 10:28:50 -0600") Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote: >> Anthony Liguori wrote: >> > On 06/14/2010 03:28 PM, Alex Williamson wrote: >> >> PCI hotplug currently doesn't work after a migration because >> >> we don't migrate the enable bits of the GPE state. Pull hotplug >> >> structs into vmstate. >> >> >> >> Signed-off-by: Alex Williamson >> >> >> > >> > Applied. Thanks. >> > >> > Regards, >> > >> > Anthony Liguori >> >> I think this is better implemented as a subsection. We didin't need >> this until hotplug arrived, I think that checking if any up/down are >> != 0 and then send it as subsections is a best way to do it. >> >> This way it could also be backported to stable. > > The slots aren't really the issue, they were mostly for completeness. > The key is gpe.en, which is likely always going to be all 1s for an ACPI > aware OS. So if we test != 0, we're going to need that subsection in > 99% of the cases. Maybe we can assume gpe.en is all set on the target, > but I don't really look forward to finding out the ways that might > break. Thanks, We have never sent it before. That means that the default value (for whatever value is it) should be working quite well. But it is not my call. Later, Juan.