From: Markus Armbruster <armbru@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Christoph Hellwig <hch@infradead.org>,
Chris Wright <chrisw@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: KVM call minutes for June 15
Date: Wed, 16 Jun 2010 08:55:00 +0200 [thread overview]
Message-ID: <m3k4pzo4aj.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <4C17A6A0.2010203@codemonkey.ws> (Anthony Liguori's message of "Tue, 15 Jun 2010 11:13:20 -0500")
Anthony Liguori <anthony@codemonkey.ws> writes:
> On 06/15/2010 10:41 AM, Christoph Hellwig wrote:
>> On Tue, Jun 15, 2010 at 08:18:12AM -0700, Chris Wright wrote:
>>
>>> KVM/qemu patches
>>> - patch rate is high, documentation is low, review is low
>>> - patches need to include better descriptions and documentation
>>> - will slow down patch writers
>>> - will make it easier for patch reviewers
>>>
>> What is the qemu patch review policy anyway?
>
> We don't really have a coherent policy. Suggestions for improvement
> are always appreciated.
>
>> There are no
>> "Reviewed-by:" included in the actual commits,
>
> Reviewed-by/Ack-by's are pretty helpful for me. In terms of including
> them in commit messages, if there's a strong feeling that that would
> be helpful then it's something I can look at doing but it also
> requires a fair bit of manual work during commit.
Can't hurt reviewer motivation. Could it be automated? Find replies,
extract tags. If you want your acks to be picked up, you better make
sure your References header works, and your tags are formatted
correctly.
[...]
next prev parent reply other threads:[~2010-06-16 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 15:18 KVM call minutes for June 15 Chris Wright
2010-06-15 15:41 ` Christoph Hellwig
2010-06-15 16:13 ` Anthony Liguori
2010-06-16 6:55 ` Markus Armbruster [this message]
2010-06-16 8:58 ` [Qemu-devel] " Yoshiaki Tamura
2010-06-16 11:55 ` Arnd Bergmann
2010-06-16 18:07 ` Blue Swirl
2010-06-17 5:15 ` Aurelien Jarno
2010-06-16 8:58 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k4pzo4aj.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=chrisw@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox