From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [PATCH] pci: Fix PCI capabilities collision error value Date: Thu, 09 Dec 2010 18:14:14 +0100 Message-ID: References: <20101209161622.10386.72203.stgit@s20.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63412 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754287Ab0LIRO1 (ORCPT ); Thu, 9 Dec 2010 12:14:27 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB9HERdU008311 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Dec 2010 12:14:27 -0500 In-Reply-To: <20101209161622.10386.72203.stgit@s20.home> (Alex Williamson's message of "Thu, 09 Dec 2010 09:16:22 -0700") Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson writes: > Signed-off-by: Alex Williamson > --- > > hw/pci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 288d6fd..0962416 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -1856,7 +1856,7 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id, > pci_find_domain(pdev->bus), pci_bus_num(pdev->bus), > PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn), > cap_id, offset, pdev->config_map[i], i); > - return -EFAULT; > + return -EINVAL; > } > } > } ACK