Re: [PATCH] device-assignment: Clear assigned_dev irq type

[Juan Quintela <quintela@redhat.com>]

Alex Williamson <alex.williamson@redhat.com> wrote:
> Commit 96abccb5 cleared assigned_irq_data.flags when an irq is disabled,
> but what we really want is to clear assigned_dev->irq_requested_type.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Found-by: Juan Quintela <quintela@redhat.com>

Acked-by: Juan Quintela <quintela@redhat.com>

> ---
>
>  hw/device-assignment.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 585162b..48ac73c 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -1044,7 +1044,7 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos)
>          if (r && r != -ENXIO)
>              perror("assigned_dev_update_msi: deassign irq");
>  
> -        assigned_irq_data.flags = 0;
> +        assigned_dev->irq_requested_type = 0;
>      }
>  
>      if (ctrl_byte & PCI_MSI_FLAGS_ENABLE) {
> @@ -1208,7 +1208,7 @@ static void assigned_dev_update_msix(PCIDevice *pci_dev, unsigned int ctrl_pos)
>          if (r && r != -ENXIO)
>              perror("assigned_dev_update_msix: deassign irq");
>  
> -        assigned_irq_data.flags = 0;
> +        assigned_dev->irq_requested_type = 0;
>      }
>  
>      if (*ctrl_word & PCI_MSIX_ENABLE) {