From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH 4/4] pci-assign: Remove broken -pcidevice and pci_add host
Date: Wed, 03 Nov 2010 14:02:38 +0100
Message-ID: <m3vd4eftld.fsf@blackfin.pond.sub.org>
References: <cover.1288709734.git.jan.kiszka@siemens.com>
	<cover.1288709734.git.jan.kiszka@siemens.com>
	<1dce616800caceaa2132daeb89ba1e703fd0115d.1288709734.git.jan.kiszka@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, "Daniel P. Berrange" <berrange@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:33372 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754633Ab0KCNCm (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 3 Nov 2010 09:02:42 -0400
In-Reply-To: <1dce616800caceaa2132daeb89ba1e703fd0115d.1288709734.git.jan.kiszka@siemens.com>
	(Jan Kiszka's message of "Tue, 2 Nov 2010 15:55:37 +0100")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Jan Kiszka <jan.kiszka@siemens.com> writes:

> These qemu-kvm-only interfaces were broken by b560a9ab9b, but no one
> complained loud enough to get them fixed again. As we have properly
> working "-device pci-assign"/"device_add" and we won't push this
> upstream anyway, there is likely no point in restoring the interface.

Agree.  Dan wrote re libvirt:

    As of libvirt >= 0.8.1 & QEMU >= 0.12.x we use switched to using
    -device for everything. Older libvirt versions had rather broken
    checking for PCI device topology, so I think it is fine to require
    libvirt >= 0.8.1 for latest QEMU releases if users want PCI dev
    assignment. Thus -pcidevice and pci_add can both be killed from our
    POV.

Note that this patch keeps pci_add nic|storage around.  Unlikely to make
it upstream.