From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string Date: Tue, 15 Jun 2010 10:53:33 +0200 Message-ID: References: <20100614054923.879.33717.stgit@localhost.localdomain> <4C15D413.6020803@redhat.com> <1276545389.12015.499.camel@x201> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gerd Hoffmann , chrisw@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, paul@codesourcery.com, avi@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47620 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756825Ab0FOIxp (ORCPT ); Tue, 15 Jun 2010 04:53:45 -0400 In-Reply-To: <1276545389.12015.499.camel@x201> (Alex Williamson's message of "Mon, 14 Jun 2010 13:56:29 -0600") Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson writes: > On Mon, 2010-06-14 at 09:02 +0200, Gerd Hoffmann wrote: >> Hi, >> >> > My premise with this attempt is that we walk the hierarchy and use the >> > names to create the base of the path. As we get to the device, >> > particularly to the parent bus of the device, we need to start looking at >> > properties to ensure uniqueness. >> >> You'll need that for every bus along the way down to the device. Create >> a virtual machine with two lsi scsi host adapters, then attach a disk >> with scsi id 0 to each. Just the scsi id isn't good enougth to identify >> the device. You'll need the lsi pci address too. > > Yep, see below. > >> > For now, the only properties I've tagged as path >> > properties are PCI bus addresses and MAC addresses. >> >> mac address isn't needed here. You need the property which specifies >> the bus address. For PCI this obviously is the PCI address. For scsi >> the scsi id. For ISA you can use the I/O port base. virtio-serial the >> port number, ... > > PCI: addr > SCSI: scsi-id > ISA: serial/parallel = iobase, others?? If there's no iobase (pathological case), require ID. > ide-drive: unit Bus name is IDE, but it's clear enough what you mean :) > I2C: address > > virtio-serial doesn't seem to make a DeviceState per port, so I think it > can be skipped. Really? Anyway, its port number should do as bus address. > I'm sure I'm still missing some... s390-virtio SSI System USB [...]