From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [PATCH 01/24] Don't disable werror unconditionally Date: Sat, 19 Sep 2009 13:41:49 +0200 Message-ID: References: <0ebec62b6a7196f970cd57cdcbcb850fdaa829bd.1253272938.git.quintela@redhat.com> <20090918190256.GA14562@amt.cnet> <4AB4AEC6.4090201@redhat.com> <4AB4BD07.3090601@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55501 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbZISLmB (ORCPT ); Sat, 19 Sep 2009 07:42:01 -0400 In-Reply-To: <4AB4BD07.3090601@web.de> (Jan Kiszka's message of "Sat, 19 Sep 2009 13:14:15 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Avi Kivity wrote: >> On 09/18/2009 10:02 PM, Marcelo Tosatti wrote: >>> On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote: >>> >>>> Signed-off-by: Juan Quintela >>>> --- >>>> configure | 2 -- >>>> 1 files changed, 0 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/configure b/configure >>>> index 97292d9..e6252a2 100755 >>>> --- a/configure >>>> +++ b/configure >>>> @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then >>>> else >>>> werror="no" >>>> fi >>>> - # disable default werror for kvm >>>> - werror="no" >>>> fi >>>> >>>> if test "$werror" = "yes" ; then >>>> >>> Don't know why Avi added this. >>> >> >> The merge which introduced this also introduced warnings into qemu-kvm. >> If the warnings are gone, it's better to restore -Werror to upstream >> behaviour. >> > > --disable-kvm builds will fail, but maybe this motivates to clean up the > related code. Failure is not -Werror related. msix.o, i8254-kvm.o and I stopped looking after that. Later, Juan.