From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Quintela Subject: Re: [RESEND PATCH] acpi_piix4: save gpe and pci hotplug slot status Date: Wed, 16 Jun 2010 17:47:18 +0200 Message-ID: References: <20100614202803.5259.85808.stgit@localhost.localdomain> <4C1697F3.3090107@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alex Williamson , qemu-devel@nongnu.org, blauwirbel@gmail.com, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26634 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755071Ab0FPPrX (ORCPT ); Wed, 16 Jun 2010 11:47:23 -0400 In-Reply-To: <4C1697F3.3090107@codemonkey.ws> (Anthony Liguori's message of "Mon, 14 Jun 2010 15:58:27 -0500") Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > On 06/14/2010 03:28 PM, Alex Williamson wrote: >> PCI hotplug currently doesn't work after a migration because >> we don't migrate the enable bits of the GPE state. Pull hotplug >> structs into vmstate. >> >> Signed-off-by: Alex Williamson >> > > Applied. Thanks. > > Regards, > > Anthony Liguori I think this is better implemented as a subsection. We didin't need this until hotplug arrived, I think that checking if any up/down are != 0 and then send it as subsections is a best way to do it. This way it could also be backported to stable. Later, Juan.