* [PATCH 0 of 3] [V2] Fix loading of registers preboot for PowerPC
@ 2008-04-10 22:15 Jerone Young
2008-04-10 22:15 ` [PATCH 1 of 3] Add kvm_load_registers into qemu_arch_init " Jerone Young
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jerone Young @ 2008-04-10 22:15 UTC (permalink / raw)
To: kvm-devel; +Cc: kvm-ppc-devel
So this now moves code away from common code to arch specific kvm_qemu_arch_init(). Also added is a removal of duplicate calls to kvm_qemu_init_env() in common code.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
3 files changed, 6 insertions(+), 4 deletions(-)
qemu/hw/ppc440_bamboo.c | 3 ---
qemu/qemu-kvm-powerpc.c | 6 ++++++
qemu/qemu-kvm.c | 1 -
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1 of 3] Add kvm_load_registers into qemu_arch_init for PowerPC
2008-04-10 22:15 [PATCH 0 of 3] [V2] Fix loading of registers preboot for PowerPC Jerone Young
@ 2008-04-10 22:15 ` Jerone Young
2008-04-10 22:15 ` [PATCH 2 of 3] Remove kvm_load_registers from ppc440_bamboo board model Jerone Young
2008-04-10 22:15 ` [PATCH 3 of 3] Remove duplicate kvm_qemu_init() calls Jerone Young
2 siblings, 0 replies; 4+ messages in thread
From: Jerone Young @ 2008-04-10 22:15 UTC (permalink / raw)
To: kvm-devel; +Cc: kvm-ppc-devel
1 file changed, 6 insertions(+)
qemu/qemu-kvm-powerpc.c | 6 ++++++
This patch adds a call to load_kvm_registers after creation of vcpu. This is required for ppc since we are required to set certain registers before boot.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
diff --git a/qemu/qemu-kvm-powerpc.c b/qemu/qemu-kvm-powerpc.c
--- a/qemu/qemu-kvm-powerpc.c
+++ b/qemu/qemu-kvm-powerpc.c
@@ -121,6 +121,12 @@ void kvm_arch_save_regs(CPUState *env)
int kvm_arch_qemu_init_env(CPUState *cenv)
{
+ if (cenv->cpu_index == 0) {
+ /* load any registers set in env into
+ kvm for the first guest vcpu */
+ kvm_load_registers(cenv);
+ }
+
return 0;
}
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2 of 3] Remove kvm_load_registers from ppc440_bamboo board model
2008-04-10 22:15 [PATCH 0 of 3] [V2] Fix loading of registers preboot for PowerPC Jerone Young
2008-04-10 22:15 ` [PATCH 1 of 3] Add kvm_load_registers into qemu_arch_init " Jerone Young
@ 2008-04-10 22:15 ` Jerone Young
2008-04-10 22:15 ` [PATCH 3 of 3] Remove duplicate kvm_qemu_init() calls Jerone Young
2 siblings, 0 replies; 4+ messages in thread
From: Jerone Young @ 2008-04-10 22:15 UTC (permalink / raw)
To: kvm-devel; +Cc: kvm-ppc-devel
1 file changed, 3 deletions(-)
qemu/hw/ppc440_bamboo.c | 3 ---
This patch removes the call to kvm_load_registers while in board platform setup code. This must now be done later in vcpu initialization.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
diff --git a/qemu/hw/ppc440_bamboo.c b/qemu/hw/ppc440_bamboo.c
--- a/qemu/hw/ppc440_bamboo.c
+++ b/qemu/hw/ppc440_bamboo.c
@@ -174,9 +174,6 @@ void bamboo_init(ram_addr_t ram_size, in
env->gpr[3] = dt_base;
#endif
env->nip = ep;
-
- printf("%s: loading kvm registers\n", __func__);
- kvm_load_registers(env);
}
for (i = 0; i < nb_nics; i++) {
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3 of 3] Remove duplicate kvm_qemu_init() calls
2008-04-10 22:15 [PATCH 0 of 3] [V2] Fix loading of registers preboot for PowerPC Jerone Young
2008-04-10 22:15 ` [PATCH 1 of 3] Add kvm_load_registers into qemu_arch_init " Jerone Young
2008-04-10 22:15 ` [PATCH 2 of 3] Remove kvm_load_registers from ppc440_bamboo board model Jerone Young
@ 2008-04-10 22:15 ` Jerone Young
2 siblings, 0 replies; 4+ messages in thread
From: Jerone Young @ 2008-04-10 22:15 UTC (permalink / raw)
To: kvm-devel; +Cc: kvm-ppc-devel
1 file changed, 1 deletion(-)
qemu/qemu-kvm.c | 1 -
kvm_qemu_init is called in ap_main_loop() , when ap_main_loop() calls kvm_main_loop_cpu(), kvm_qemu_init() is run for a second time. It should only be called in kvm_main_loop_cpu().
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
~
diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c
--- a/qemu/qemu-kvm.c
+++ b/qemu/qemu-kvm.c
@@ -353,7 +353,6 @@ static void *ap_main_loop(void *_env)
sigdelset(&signals, SIG_IPI);
sigprocmask(SIG_BLOCK, &signals, NULL);
kvm_create_vcpu(kvm_context, env->cpu_index);
- kvm_qemu_init_env(env);
if (kvm_irqchip_in_kernel(kvm_context))
env->hflags &= ~HF_HALTED_MASK;
kvm_main_loop_cpu(env);
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-10 22:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-10 22:15 [PATCH 0 of 3] [V2] Fix loading of registers preboot for PowerPC Jerone Young
2008-04-10 22:15 ` [PATCH 1 of 3] Add kvm_load_registers into qemu_arch_init " Jerone Young
2008-04-10 22:15 ` [PATCH 2 of 3] Remove kvm_load_registers from ppc440_bamboo board model Jerone Young
2008-04-10 22:15 ` [PATCH 3 of 3] Remove duplicate kvm_qemu_init() calls Jerone Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox