public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Konstantin Ozerkov <kozerkov@parallels.com>,
	KVM list <kvm@vger.kernel.org>, Denis Lunev <den@parallels.com>,
	qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>,
	"Denis V. Lunev \(openvz\)" <den@openvz.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Wierd hack to sound/pci/intel8x0.c
Date: Mon, 07 Nov 2011 11:45:18 +0100	[thread overview]
Message-ID: <s5hd3d45hz5.wl%tiwai@suse.de> (raw)
In-Reply-To: <4EB7B485.3090907@redhat.com>

At Mon, 07 Nov 2011 11:35:49 +0100,
Gerd Hoffmann wrote:
> 
>   Hi,
> 
> > We discuss Intel ICH/AC'97 (snd-intel8x0) here, but I hope that PCI SSID
> > is same.
> 
> Hmm, it's not, the ac97 emulation doesn't use the default qemu subsystem
> id for some reason.  Here is the entry:
> 
> [root@fedora ~]# lspci -vns6
> 00:06.0 0401: 8086:2415 (rev 01)
>         Subsystem: 8086:0000
>         Physical Slot: 6
>         Flags: bus master, medium devsel, latency 0, IRQ 10
>         I/O ports at c000 [size=1K]
>         I/O ports at c400 [size=256]
>         Kernel driver in use: Intel ICH
>         Kernel modules: snd-intel8x0
> 
> I guess that should be fixed.  8086:0000 isn't valid anyway and I doubt
> it serves any useful purpose other than avoiding a guest complaining
> about the subsystem id being unset.

Yeah, especially the value 0 looks pretty bad.

> /me goes preparing a patch.

Thanks!


Takashi

  reply	other threads:[~2011-11-07 10:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-06 14:51 Wierd hack to sound/pci/intel8x0.c Avi Kivity
2011-11-06 16:15 ` Denis V. Lunev
2011-11-06 16:31   ` Avi Kivity
2011-11-06 16:47     ` Takashi Iwai
2011-11-06 16:56       ` Denis V. Lunev
2011-11-06 16:50     ` Denis V. Lunev
2011-11-06 16:33   ` Takashi Iwai
2011-11-07  9:25     ` Gerd Hoffmann
2011-11-07  9:52       ` Konstantin Ozerkov
2011-11-07 10:35         ` Gerd Hoffmann
2011-11-07 10:45           ` Takashi Iwai [this message]
2011-11-07 10:44       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd3d45hz5.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=avi@redhat.com \
    --cc=den@openvz.org \
    --cc=den@parallels.com \
    --cc=kozerkov@parallels.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox