From: sashiko-bot@kernel.org
To: "Leon Romanovsky" <leon@kernel.org>
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org,
media-ci@linuxtv.org
Subject: Re: [PATCH v10 02/18] PCI/P2PDMA: Derive routing from directional ACS controls
Date: Mon, 12 Oct 2026 13:16:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-168158@kernel.org> (raw)
In-Reply-To: <20261012-fix-p2p-acs-v4-0-v10-2-6ffe7b7a4517@nvidia.com>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> pci_bridge_has_acs_redir() treats Request and Completion Redirect as
> interchangeable. On asymmetric fabrics, a control for only the reverse TLP
> direction can unnecessarily force P2PDMA through the host bridge.
>
> Evaluate Request Redirect for the Requester's Requests and Completion
> Redirect for the Completer's read Completions. Continue treating enabled
> Egress Control conservatively as a Request redirect.
>
> Fixes: 52916982af48 ("PCI/P2PDMA: Support peer-to-peer memory")
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> Tested-by: Tushar Dave <tdave@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-fix-p2p-acs-v4-0-v10-0-6ffe7b7a4517@nvidia.com?part=2
next prev parent reply other threads:[~2026-10-12 13:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:07 [PATCH v10 00/18] PCI/P2PDMA: Route peer-to-peer DMA by TLP class Leon Romanovsky
2026-10-12 13:07 ` [PATCH v10 01/18] PCI/P2PDMA: Document the TLP attribute assumptions Leon Romanovsky
2026-10-12 13:11 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 02/18] PCI/P2PDMA: Derive routing from directional ACS controls Leon Romanovsky
2026-10-12 13:16 ` sashiko-bot [this message]
2026-10-12 13:07 ` [PATCH v10 03/18] PCI: Reject unreadable ACS controls in isolation checks Leon Romanovsky
2026-10-12 13:20 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 04/18] PCI/P2PDMA: Evaluate ACS controls at the path divergence Leon Romanovsky
2026-10-12 13:15 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 05/18] PCI/P2PDMA: Document directional ACS routing Leon Romanovsky
2026-10-12 13:15 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 06/18] PCI/P2PDMA: Collect the path's ACS controls before deciding Leon Romanovsky
2026-10-12 13:15 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 07/18] PCI/P2PDMA: Answer routing per TLP class Leon Romanovsky
2026-10-12 13:18 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 08/18] PCI/P2PDMA: Route Relaxed Ordering Completions directly Leon Romanovsky
2026-10-12 13:18 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 09/18] PCI/P2PDMA: Reject Translated Requests blocked by Translation Blocking Leon Romanovsky
2026-10-12 13:20 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 10/18] PCI/P2PDMA: Route Translated Requests under Direct Translated P2P Leon Romanovsky
2026-10-12 13:15 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 11/18] PCI/P2PDMA: Log detailed ACS routing diagnostics Leon Romanovsky
2026-10-12 13:18 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 12/18] PCI/P2PDMA: Add KUnit tests for the ACS routing decisions Leon Romanovsky
2026-10-12 13:19 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 13/18] PCI/P2PDMA: Test the ACS P2P routing walk Leon Romanovsky
2026-10-12 13:23 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 14/18] PCI: Add KUnit coverage for ACS isolation checks Leon Romanovsky
2026-10-12 13:20 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 15/18] PCI/P2PDMA: Document TLP-class routing Leon Romanovsky
2026-10-12 13:16 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 16/18] PCI/P2PDMA: Let a client declare that it selects ATS per mapping Leon Romanovsky
2026-10-12 13:26 ` sashiko-bot
2026-10-12 13:07 ` [PATCH v10 17/18] PCI/P2PDMA: Evaluate the ATS path for clients with ATS enabled Leon Romanovsky
2026-10-12 13:27 ` sashiko-bot
2026-10-12 18:08 ` Leon Romanovsky
2026-10-12 13:07 ` [PATCH v10 18/18] PCI/P2PDMA: Test the routing of " Leon Romanovsky
2026-10-12 13:24 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-168158@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox