Re: [PATCH 1/7] KVM: arm64: nv: Move L2->L1 switch on interrupt early

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kvm: Outdated comment block in kvm_vgic_flush_hwstate()
--

commit 8603da24ffa95dd560817192077ee16c16570bf2
Author: Marc Zyngier <maz@kernel.org>

KVM: arm64: nv: Move L2->L1 switch on interrupt early

This commit moves the nested request generation for L2->L1 switch on
interrupt and the maintenance interrupt (MI) generation to earlier in
the vCPU entry sequence.

> diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c
> index b25303d9919fd..1748e7758681b 100644
> --- a/arch/arm64/kvm/vgic/vgic.c
> +++ b/arch/arm64/kvm/vgic/vgic.c
> @@ -1141,7 +1141,7 @@ void kvm_vgic_flush_hwstate(struct kvm_vcpu *vcpu)
[ ... ]
>  	 * - Otherwise, do exactly *NOTHING* apart from enabling the virtual
>  	 *   CPU interface. The guest state is already loaded, and we can
>  	 *   carry on with running it.
>  	 *
>  	 * If we have NV, but are not in a nested state, compute the
>  	 * maintenance interrupt state, as it may fire.
>  	 */
>  	if (vgic_state_is_nested(vcpu)) {

[Severity: Low]
This isn't a bug, but should this comment block in kvm_vgic_flush_hwstate()
be updated?

The patch moves the execution of vgic_v3_nested_update_mi() to
kvm_nested_flush_hwstate(), so the note about computing the maintenance
interrupt state here appears to be outdated now.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015100539.1011760-1-maz@kernel.org?part=1