Re: [PATCH] KVM: SVM: Sync CR8 to the local APIC after marking the VMCB clean

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] KVM: SVM: missing Signed-off-by trailer from patch author
--

commit 233803838af902e26ce77bf3e6c981b3c2991bd9
Author: Chris Oo <cho@microsoft.com>

> KVM: SVM: Sync CR8 to the local APIC after marking the VMCB clean
>
> Sync CR8 from the VMCB to the TPR *after* marking all VMCB fields as clean,
> as syncing CR8 can toggle the CR8 write intercept and thus mark INTERCEPTS
> as dirty.  Clobbering the dirty bit can result in KVM failing to detect CR8
> writes if the underlying "hardware" uses the clean bits to optimize VMRUN,
> e.g. when KVM is running on Hyper-V.
>
> Failure to intercept CR8 usually manifests as hangs when running Windows as
> L2, as KVM's view of vTPR stays high and so KVM never injects pending IRQs.
>
> Fixes: bb365a506b1e ("KVM: x86: Unconditionally recompute CR8 intercept on PPR update")
> Cc: stable@vger.kernel.org
> Cc: Carlos López <clopez@suse.de>
> Cc: Stefano Garzarella <sgarzare@redhat.com>
> Not-signed-off-by: Chris Oo <cho@microsoft.com>
> [sean: rewrite changelog, massage comment]
> Signed-off-by: Sean Christopherson <seanjc@google.com>

[Severity: High]
As noted below the tearline, the patch author's Signed-off-by trailer is
missing and currently listed as Not-signed-off-by.  A Signed-off-by from
Chris Oo <cho@microsoft.com> is required under the Developer's Certificate
of Origin before this commit can be merged.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113162556.461390-1-seanjc@google.com?part=1