From: sashiko-bot@kernel.org
To: "Chengwen Feng" <fengchengwen@huawei.com>
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v21 07/13] PCI/TPH: Add pcie_tph_set_st_entries() batch ST entry programming helper
Date: Wed, 18 Nov 2026 10:15:19 +0000 [thread overview]
Message-ID: <sashiko-outbox-220669@kernel.org> (raw)
In-Reply-To: <20261118091238.45992-8-fengchengwen@huawei.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] PCI/TPH: pcie_tph_set_st_entries() disables TPH on partial
write
--
commit 8c13933953bfa21006225cd4609cb9e61ae70514
Author: Chengwen Feng <fengchengwen@huawei.com>
PCI/TPH: Add pcie_tph_set_st_entries() batch ST entry programming helper
This commit adds pcie_tph_set_st_entries() to program a contiguous range
of Steering Tag table entries in a batch while disabling and re-enabling
TPH once per batch, and rewrites pcie_tph_set_st_entry() as a wrapper
around it.
> diff --git a/drivers/pci/tph.c b/drivers/pci/tph.c
> index 51a065d83104b..c8b867dd233d4 100644
> --- a/drivers/pci/tph.c
> +++ b/drivers/pci/tph.c
[ ... ]
> @@ -344,29 +345,47 @@ int pcie_tph_set_st_entry(struct pci_dev *pdev, unsigned int index, u16 tag)
> set_ctrl_reg_req_en(pdev, PCI_TPH_REQ_DISABLE);
>
> loc = pcie_tph_get_st_table_loc(pdev);
> -
> - switch (loc) {
> - case PCI_TPH_LOC_MSIX:
> - err = pci_msix_write_tph_tag(pdev, index, tag);
> - break;
> - case PCI_TPH_LOC_CAP:
> - err = write_tag_to_st_table(pdev, index, tag);
> - break;
> - default:
> - err = -EINVAL;
> - }
> -
> - if (err) {
> - pcie_disable_tph(pdev);
> - return err;
> + for (i = 0; i < count; i++) {
> + switch (loc) {
> + case PCI_TPH_LOC_MSIX:
> + err = pci_msix_write_tph_tag(pdev, start + i, tags[i]);
> + break;
> + case PCI_TPH_LOC_CAP:
> + err = write_tag_to_st_table(pdev, start + i, tags[i]);
> + break;
> + default:
> + err = -EINVAL;
> + }
> + if (err != 0) {
> + pci_err(pdev, "failed to set steering tag: %s table, index=%u, tags=%u, ret=%d\n",
> + (loc == PCI_TPH_LOC_MSIX) ? "MSI-X" : "ST",
> + start + i, tags[i], err);
> + pcie_disable_tph(pdev);
> + return i > 0 ? i : (err > 0 ? -EINVAL : err);
> + }
> }
[Severity: Medium]
Should pcie_tph_set_st_entries() call pcie_disable_tph(pdev) when
returning a positive entry count i on a partial write?
If a batch write succeeds for the first i > 0 entries and fails on entry
start + i (for example, when start + i reaches st_table_size so
write_tag_to_st_table() returns -ENXIO), pcie_disable_tph(pdev) writes 0
to PCI_TPH_CTRL and clears pdev->tph_mode, pdev->tph_req_type, and
pdev->tph_enabled before returning i. The caller is told that i entries
were programmed, but TPH is now disabled on the device and any subsequent
call to pcie_tph_set_st_entries() or pcie_tph_set_st_entry() will fail
with -EINVAL because pdev->tph_enabled is 0.
When i > 0, re-enabling TPH via set_ctrl_reg_req_en(pdev,
pdev->tph_req_type) instead of calling pcie_disable_tph(pdev) would keep
the programmed entries usable, or else the function should return a
negative errno whenever it disables TPH.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118091238.45992-1-fengchengwen@huawei.com?part=7
next prev parent reply other threads:[~2026-11-18 10:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 9:12 [PATCH v21 00/13] vfio/pci: Add PCIe TPH support Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 01/13] PCI/TPH: Fix pcie_tph_get_st_table_loc() field extraction Chengwen Feng
2026-11-18 9:29 ` sashiko-bot
2026-11-18 9:12 ` [PATCH v21 02/13] PCI/TPH: Fix tph_enabled concurrent update race by bitfield packing Chengwen Feng
2026-11-18 9:38 ` sashiko-bot
2026-11-18 9:12 ` [PATCH v21 03/13] PCI/TPH: Cache negotiated max requester type at probe time Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 04/13] PCI/TPH: Refactor pcie_enable_tph and add requester variant Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 05/13] PCI/TPH: Refactor pcie_tph_get_cpu_st & " Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 06/13] PCI/TPH: Add macros to check standard and extended TPH support Chengwen Feng
2026-11-18 10:06 ` sashiko-bot
2026-11-18 9:12 ` [PATCH v21 07/13] PCI/TPH: Add pcie_tph_set_st_entries() batch ST entry programming helper Chengwen Feng
2026-11-18 10:15 ` sashiko-bot [this message]
2026-11-18 9:12 ` [PATCH v21 08/13] PCI/TPH: Add pci_tph_dsm_supported() helper to detect device TPH ST _DSM Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 09/13] vfio/pci: Add basic NO-ST TPH VFIO device feature support Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 10/13] vfio/pci: Add IV-ST TPH policy and TPH_PROGRAM batch programming support Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 11/13] vfio/pci: Add DS-ST TPH policy and TPH_RESOLVE capability Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 12/13] vfio/pci: Reset PCIe TPH state on device open and close Chengwen Feng
2026-11-18 9:12 ` [PATCH v21 13/13] vfio/pci: Expose per-device TPH state via debugfs Chengwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220669@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=fengchengwen@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox