From mboxrd@z Thu Jan 1 00:00:00 1970 From: Changli Gao Subject: Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer. Date: Sun, 25 Apr 2010 17:35:01 +0800 Message-ID: References: <1272187206-18534-1-git-send-email-xiaohui.xin@intel.com> <1272187206-18534-2-git-send-email-xiaohui.xin@intel.com> <1272187206-18534-3-git-send-email-xiaohui.xin@intel.com> <1272187206-18534-4-git-send-email-xiaohui.xin@intel.com> <1272187206-18534-5-git-send-email-xiaohui.xin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu, davem@davemloft.net, jdike@linux.intel.com To: xiaohui.xin@intel.com Return-path: Received: from mail-iw0-f178.google.com ([209.85.223.178]:49780 "EHLO mail-iw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752653Ab0DYJff convert rfc822-to-8bit (ORCPT ); Sun, 25 Apr 2010 05:35:35 -0400 In-Reply-To: <1272187206-18534-5-git-send-email-xiaohui.xin@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Apr 25, 2010 at 5:19 PM, wrote: > +static int dev_is_mpassthru(struct net_device *dev) bool return value should be better here. --=20 Regards=EF=BC=8C Changli Gao(xiaosuo@gmail.com)