From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Nazarewicz Subject: Re: [PATCH v2 01/10] DMA, CMA: clean-up log message Date: Thu, 12 Jun 2014 11:53:16 +0200 Message-ID: References: <1402543307-29800-1-git-send-email-iamjoonsoo.kim@lge.com> <1402543307-29800-2-git-send-email-iamjoonsoo.kim@lge.com> <87y4x2pwnk.fsf@linux.vnet.ibm.com> <20140612055358.GA30128@js1304-P5Q-DELUXE> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , Marek Szyprowski , Minchan Kim , Russell King - ARM Linux , Greg Kroah-Hartman , Paolo Bonzini , Gleb Natapov , Alexander Graf , Benjamin Herrenschmidt , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org To: Joonsoo Kim , "Aneesh Kumar K.V" Return-path: In-Reply-To: Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Jun 12 2014, Michal Nazarewicz wrote: > I used =E2=80=9Cfunction(arg1, arg2, =E2=80=A6)=E2=80=9D at the *begi= nning* of functions when > the arguments passed to the function were included in the message. I= n > all other cases I left it at just =E2=80=9Cfunction:=E2=80=9D (or jus= t no additional > prefix). IMO that's a reasonable strategy. At closer inspection, I realised drivers/base/dma-contiguous.c is Marek's code, but the above I think is still reasonable thing to do, so I'd rather standardise on having =E2=80=9Cfunction(=E2=80=A6)=E2=80=9D = only at the beginning of a function. Just my 0.02 CHF. --=20 Best regards, _ _ =2Eo. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o =2E.o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarew= icz (o o) ooo +------ooO--(_)--Ooo--