From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Nazarewicz Subject: Re: [PATCH v2 01/10] DMA, CMA: clean-up log message Date: Thu, 12 Jun 2014 10:55:32 +0200 Message-ID: References: <1402543307-29800-1-git-send-email-iamjoonsoo.kim@lge.com> <1402543307-29800-2-git-send-email-iamjoonsoo.kim@lge.com> <87y4x2pwnk.fsf@linux.vnet.ibm.com> <20140612055358.GA30128@js1304-P5Q-DELUXE> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , Marek Szyprowski , Minchan Kim , Russell King - ARM Linux , Greg Kroah-Hartman , Paolo Bonzini , Gleb Natapov , Alexander Graf , Benjamin Herrenschmidt , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org To: Joonsoo Kim , "Aneesh Kumar K.V" Return-path: In-Reply-To: <20140612055358.GA30128@js1304-P5Q-DELUXE> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org >> Joonsoo Kim writes: >>=20 >> > We don't need explicit 'CMA:' prefix, since we already define pref= ix >> > 'cma:' in pr_fmt. So remove it. >> > >> > And, some logs print function name and others doesn't. This looks >> > bad to me, so I unify log format to print function name consistent= ly. >> > >> > Lastly, I add one more debug log on cma_activate_area(). >> > >> > Signed-off-by: Joonsoo Kim >> > >> > diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-cont= iguous.c >> > index 83969f8..bd0bb81 100644 >> > --- a/drivers/base/dma-contiguous.c >> > +++ b/drivers/base/dma-contiguous.c >> > @@ -144,7 +144,7 @@ void __init dma_contiguous_reserve(phys_addr_t= limit) >> > } >> > >> > if (selected_size && !dma_contiguous_default_area) { >> > - pr_debug("%s: reserving %ld MiB for global area\n", __func__, >> > + pr_debug("%s(): reserving %ld MiB for global area\n", __func__, >> > (unsigned long)selected_size / SZ_1M); > On Thu, Jun 12, 2014 at 10:11:19AM +0530, Aneesh Kumar K.V wrote: >> Do we need to do function(), or just function:. I have seen the late= r >> usage in other parts of the kernel. On Thu, Jun 12 2014, Joonsoo Kim wrote: > I also haven't seen this format in other kernel code, but, in cma, th= ey use > this format as following. > > function(arg1, arg2, ...): some message > > If we all dislike this format, we can change it after merging this > patchset. Until then, it seems better to me to leave it as is. I used =E2=80=9Cfunction(arg1, arg2, =E2=80=A6)=E2=80=9D at the *beginn= ing* of functions when the arguments passed to the function were included in the message. In all other cases I left it at just =E2=80=9Cfunction:=E2=80=9D (or just = no additional prefix). IMO that's a reasonable strategy. --=20 Best regards, _ _ =2Eo. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o =2E.o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarew= icz (o o) ooo +------ooO--(_)--Ooo--