From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6401F2D1907; Mon, 3 Nov 2025 07:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762156643; cv=none; b=EF6QRezUPv4F58o2MmNVgGoVZI2R3qeuoni3vwsC7jJna2vEY2dkFw8Q6iXqK9sSZKMuwxV/IAHCiNCMSJscGp+h3JnmE42jKL3MBf58QDzoWneyN31z+V9XdFVS2OVabg4OHMcQd1bB5WZ+Ysg+eVwzb320vLfZK6tt+OB1+2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762156643; c=relaxed/simple; bh=HSj/Z5n0gDZ4meqwx9ffw43W8XomEOuc7B2mT893bzs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=N3M+ucM8M+7Ghcbz26qodnLJtUpcMl+eSg4WI2iWqmH4yKzGdg82SsxvJwrLUrzQczXL4+VEwiTTpfpwK2niD3tzYwUHQw6289ITNh2EyJp4wuOGgeIYCsT1MFRDiVG/OHAVu/8C0kIv9gW4s9NQMtGCgcY4YlHZzli/QASK16Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EyuFXS/5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EyuFXS/5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A78AEC4CEE7; Mon, 3 Nov 2025 07:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762156642; bh=HSj/Z5n0gDZ4meqwx9ffw43W8XomEOuc7B2mT893bzs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EyuFXS/5i8cjPsKl1fmDKJwxtvpzPfkDrVD/7Dw9cVg4MIRSZ9pwX9Mwp3TkQNtyw zoeqzLLyxPRNqLWKH6FXNg+6ZNo7vj4V4K1a2Q2k642McCDmgxisCjpK6A9S/QL1M+ JohKsDSLySE14H0H5z5GG8d356N9+qgQ55m+uwsMsRoTogFqUE9iZVhmwTsjaJxJ0D rf7CiQwNGNOSkhhNm3a8Kegsyv/wACFQk0qTNci2kW/sBtJn3XjoC3JgBMB4DLxEd1 BxbJrOVgc9EcBq/f6dV64raqbuuFvwCKqXqgbvNuoO3N0Gl4d4KOsuqDiCv8HqbTcE IGGXAlmxritEQ== X-Mailer: emacs 30.2 (via feedmail 11-beta-1 I) From: Aneesh Kumar K.V To: "Roy, Patrick" Cc: "Roy, Patrick" , "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "david@redhat.com" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "song@kernel.org" , "jolsa@kernel.org" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "seanjc@google.com" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "Cali, Marco" , "Kalyazin, Nikita" , "Thomson, Jack" , "derekmn@amazon.co.uk" , "tabba@google.com" , "ackerleytng@google.com" Subject: Re: [PATCH v7 05/12] KVM: guest_memfd: Add flag to remove from direct map In-Reply-To: <20250924152214.7292-2-roypat@amazon.co.uk> References: <20250924151101.2225820-4-patrick.roy@campus.lmu.de> <20250924152214.7292-1-roypat@amazon.co.uk> <20250924152214.7292-2-roypat@amazon.co.uk> Date: Mon, 03 Nov 2025 13:27:04 +0530 Message-ID: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Roy, Patrick" writes: .... > +static int kvm_gmem_folio_zap_direct_map(struct folio *folio) > +{ > + if (kvm_gmem_folio_no_direct_map(folio)) > + return 0; > + > + int r =3D set_direct_map_valid_noflush(folio_page(folio, 0), folio_nr_p= ages(folio), > + false); > + > + if (!r) { > + unsigned long addr =3D (unsigned long) folio_address(folio); > + folio->private =3D (void *) ((u64) folio->private & KVM_GMEM_FOLIO_NO_= DIRECT_MAP); > + flush_tlb_kernel_range(addr, addr + folio_size(folio)); > + } > + > + return r; > +} These 'noflush' functions are actually doing flush_tlb_kernel [-] =E2=88=98 flush_tlb_kernel_range |-[-] =E2=86=90 __change_memory_common | `-[-] =E2=86=90 set_memory_valid | `- =E2=86=90 set_direct_map_valid_noflush -aneesh