From: Pavel Fedin <p.fedin@samsung.com>
To: 'Christoffer Dall' <christoffer.dall@linaro.org>
Cc: 'Marc Zyngier' <marc.zyngier@arm.com>,
'Andre Przywara' <andre.przywara@arm.com>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: RE: [PATCH v4 0/3] KVM: arm/arm64: Clean up some obsolete code
Date: Thu, 05 Nov 2015 09:50:44 +0300 [thread overview]
Message-ID: <01d001d11796$4c1c4770$e454d650$@samsung.com> (raw)
In-Reply-To: <20151104142926.GA20230@cbox>
Hello!
> Actually, I seem to have been just incredibly unlucky with my test
> cycles, because I eventually reproduced the bug without your patches.
Or lucky, without "un" :)
> I'm going to take this version of the series because that's what I
> reviewed and tested.
It's OK, as i wrote, v5 is no different from v4 actually, just 0001 bisected. And making it was useful because it helped me to make
sure once again that i haven't messed anything up.
> Sorry for the noise.
It's OK, thank you very much for putting efforts into testing and cooperation.
You know, since we are talking about this... This definitely has something to do with the reset, and... Looks like nobody resets
vGIC/vTimer, unless the userland does it explicitly by resetting every register by hand.
I know, there is no global "reset" function for the whole VM. But, at least we have reset ioctl for vCPU. What if we hook up
vGIC/vTimer there, and reset at least per-CPU objects (CPU interface + redist + timer) at this point?
P.S. I've seen your PULL, and it is missing a little thing that could be good for 4.4 too. I've fixed one more bug recently, it
reproduces on CP15-timer-less boards like Exynos: http://www.spinics.net/lists/kvm/msg122746.html. Just to make sure that you don't
miss it.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-11-05 6:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 8:37 [PATCH v4 0/3] KVM: arm/arm64: Clean up some obsolete code Pavel Fedin
2015-10-27 8:37 ` [PATCH v4 1/3] KVM: arm/arm64: Optimize away redundant LR tracking Pavel Fedin
2015-10-27 8:37 ` [PATCH v4 2/3] KVM: arm/arm64: Clean up vgic_retire_lr() and surroundings Pavel Fedin
2015-10-27 8:37 ` [PATCH v4 3/3] KVM: arm/arm64: Merge vgic_set_lr() and vgic_sync_lr_elrsr() Pavel Fedin
2015-11-02 21:15 ` [PATCH v4 0/3] KVM: arm/arm64: Clean up some obsolete code Christoffer Dall
2015-11-03 7:24 ` Pavel Fedin
2015-11-03 9:44 ` Pavel Fedin
2015-11-04 14:29 ` Christoffer Dall
2015-11-05 6:50 ` Pavel Fedin [this message]
2015-11-05 8:05 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01d001d11796$4c1c4770$e454d650$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=andre.przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox