From: Marc Zyngier <maz@kernel.org>
To: Andrew Scull <ascull@google.com>
Cc: kernel-team@android.com,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3 5/5] KVM: arm64: Log source when panicking from nVHE hyp
Date: Fri, 19 Mar 2021 10:42:28 +0000 [thread overview]
Message-ID: <05382db2bb80997e7f5f9c66a4669bf9@kernel.org> (raw)
In-Reply-To: <CADcWuH3aP8yWbh5mYbgEqjpqvRT8R6HFp814BiZevQAc_o-1+Q@mail.gmail.com>
On 2021-03-19 10:38, Andrew Scull wrote:
>> > > diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
>> > > index 90873851f677..7c17a67d2291 100644
>> > > --- a/arch/arm64/include/asm/kvm_mmu.h
>> > > +++ b/arch/arm64/include/asm/kvm_mmu.h
>> > > @@ -121,6 +121,8 @@ void kvm_update_va_mask(struct alt_instr *alt,
>> > > void kvm_compute_layout(void);
>> > > void kvm_apply_hyp_relocations(void);
>> > >
>> > > +#define __hyp_pa(x) (((phys_addr_t)(x)) + hyp_physvirt_offset)
>> >
>> > Just a heads up: but Quentin's series moves this same macro, but to a
>> > different header (arch/arm64/kvm/hyp/include/nvhe/memory.h)
>>
>> I can make sure we're putting it in the same header to ease the merge.
>
> Seems I was too optimistic since nvhe/memory.h can only be used from
> nVHE hyp. I could rebase no top of Quentin to move the macro somewhere
> that can be used from here, but that would add a series dependency
> that you usually seem to try and avoid so I'm not going to change
> this, unless you'd prefer that I do.
I can deal with this at merge time.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2021-03-19 10:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 14:33 [PATCH v3 0/5] Debug info for nVHE hyp panics Andrew Scull
2021-03-18 14:33 ` [PATCH v3 1/5] bug: Remove redundant condition check in report_bug Andrew Scull
2021-03-18 15:17 ` Will Deacon
2021-03-18 14:33 ` [PATCH v3 2/5] bug: Factor out a getter for a bug's file line Andrew Scull
2021-03-18 15:19 ` Will Deacon
2021-03-18 14:33 ` [PATCH v3 3/5] bug: Assign values once in bug_get_file_line() Andrew Scull
2021-03-18 15:22 ` Will Deacon
2021-03-18 14:33 ` [PATCH v3 4/5] KVM: arm64: Use BUG and BUG_ON in nVHE hyp Andrew Scull
2021-03-18 15:25 ` Will Deacon
2021-03-18 14:33 ` [PATCH v3 5/5] KVM: arm64: Log source when panicking from " Andrew Scull
2021-03-18 16:59 ` Will Deacon
2021-03-19 9:51 ` Marc Zyngier
2021-03-19 9:59 ` Andrew Scull
2021-03-19 10:38 ` Andrew Scull
2021-03-19 10:42 ` Marc Zyngier [this message]
2021-04-01 9:26 ` [PATCH v3 0/5] Debug info for nVHE hyp panics Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05382db2bb80997e7f5f9c66a4669bf9@kernel.org \
--to=maz@kernel.org \
--cc=ascull@google.com \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox