From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Cc: pbonzini@redhat.com
Subject: Re: [PATCH kvm-unit-tests] arm: Enable the VFP
Date: Thu, 28 Nov 2019 16:15:06 +0100 [thread overview]
Message-ID: <05576e71-eb32-e41f-5631-1cd90b4dddd5@redhat.com> (raw)
In-Reply-To: <20191128143421.13815-1-drjones@redhat.com>
On 28/11/2019 15.34, Andrew Jones wrote:
> Variable argument macros frequently depend on floating point
> registers. Indeed we needed to enable the VFP for arm64 since its
> introduction in order to use printf and the like. Somehow we
> didn't need to do that for arm32 until recently when compiling
> with GCC 9.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>
> CC'ing Thomas because I think he had to workaround travis tests
> failing due to this issue once. Maybe travis can now be
> un-worked-around?
Yes, this patch fixes the problem with GCC9 for me:
https://gitlab.com/huth/kvm-unit-tests/-/jobs/364079089
Feel free to add my
Tested-by: Thomas Huth <thuth@redhat.com>
and if you like, please also include this hunk:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -17,7 +17,7 @@ build-aarch64:
build-arm:
script:
- - dnf install -y qemu-system-arm gcc-arm-linux-gnu-8.2.1-1.fc30.2
+ - dnf install -y qemu-system-arm gcc-arm-linux-gnu
- ./configure --arch=arm --cross-prefix=arm-linux-gnu-
- make -j2
- ACCEL=tcg ./run_tests.sh
Thomas
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
prev parent reply other threads:[~2019-11-28 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 14:34 [PATCH kvm-unit-tests] arm: Enable the VFP Andrew Jones
2019-11-28 15:06 ` Andrew Jones
2019-11-28 15:15 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05576e71-eb32-e41f-5631-1cd90b4dddd5@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox