From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2091BC433FE for ; Wed, 10 Nov 2021 17:00:30 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 875C161267 for ; Wed, 10 Nov 2021 17:00:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 875C161267 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C52214B22C; Wed, 10 Nov 2021 12:00:28 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PXt-7-WUS6Bn; Wed, 10 Nov 2021 12:00:27 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 204FB4B204; Wed, 10 Nov 2021 12:00:27 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 844794B1EF for ; Wed, 10 Nov 2021 12:00:25 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WK32XTeL1jI3 for ; Wed, 10 Nov 2021 12:00:20 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 812714B1ED for ; Wed, 10 Nov 2021 12:00:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636563620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j4pYydCf5K8wTsOHmFWFndJrj56wgud3cb8m0v50g38=; b=cJkE5DasWvfT2s7xPKgOqnV6dCshD4s41mXkfQU7rdnS780HVBgNTy35dKbNmoilEwWcbt TtydiY8FACzy5Z2OaMiGF7GxD1t5LipGZRMPlRNwCnS7Xhu4WugZUUocgFJW4Il8dlI6dU RlqlvILpJ/G6AUFj2GZ0pu0NCYUoZwA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-593-DY7n6p9NPYmcAlU0APtLWA-1; Wed, 10 Nov 2021 12:00:17 -0500 X-MC-Unique: DY7n6p9NPYmcAlU0APtLWA-1 Received: by mail-wm1-f71.google.com with SMTP id l4-20020a05600c1d0400b00332f47a0fa3so1429083wms.8 for ; Wed, 10 Nov 2021 09:00:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j4pYydCf5K8wTsOHmFWFndJrj56wgud3cb8m0v50g38=; b=OTLMYz2NBMbAP57+FWQd8oVsqGaaUVUOUrM5rt1Tp5eybj2O1d9EoQ/0/oN087lHT9 1ZXngYAI5XDYABZv8UT7RJQWdQvnVj2iALRwa9GLXdjIHoI46s+4XF3NTjZZj+nlFqvr dVmO6NNUmqSHsu0TAVSG3Ge3q/viNvKlxUmVo3nWb4hVOQKsuMxMUPRNoaPYTbZdA+4g MPI8KCyxOrhRF28dlWrHxKIevrp7p5bKYME9u1u0aFO9G03l4JKSFUEeZyyuFTEL00DP BWiSlCevnCpCYAgaLPiT+l3SPz4rMwgqZage7Bv1CGzXKR0WuPvp7igX9vaUhUdFkuru +Nmw== X-Gm-Message-State: AOAM533hOlFRXqqXRMVlmT7VCHyozzNj9PkuVZ1PTsXm3Pfum/j6l4Fi wFNWcACoIHKTWQZigjb2tR14WyDZZ3L11He1FTquUN357Gxz/BGGR1WOrJl1W/EIO6tZvB9Rsgn wMjf9vrxiPThnQwmF+00qbiK+ X-Received: by 2002:a1c:43c1:: with SMTP id q184mr18128557wma.153.1636563615737; Wed, 10 Nov 2021 09:00:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzI55jyDNoSB30zudIHtQh+iKpj0BpgPN8b1JOQeacltE6fInNdbDMoAUO3wu73arG51UEabg== X-Received: by 2002:a1c:43c1:: with SMTP id q184mr18128529wma.153.1636563615493; Wed, 10 Nov 2021 09:00:15 -0800 (PST) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id z6sm434734wmp.1.2021.11.10.09.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Nov 2021 09:00:14 -0800 (PST) Subject: Re: [PATCH v4 03/15] KVM: async_pf: Make GFN slot management generic To: Gavin Shan , kvmarm@lists.cs.columbia.edu References: <20210815005947.83699-1-gshan@redhat.com> <20210815005947.83699-4-gshan@redhat.com> From: Eric Auger Message-ID: <06cb06c0-13e7-906b-9b88-543a58bb5590@redhat.com> Date: Wed, 10 Nov 2021 18:00:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210815005947.83699-4-gshan@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eauger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: kvm@vger.kernel.org, maz@kernel.org, linux-kernel@vger.kernel.org, shan.gavin@gmail.com, Jonathan.Cameron@huawei.com, pbonzini@redhat.com, vkuznets@redhat.com, will@kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Gavin, On 8/15/21 2:59 AM, Gavin Shan wrote: > It's not allowed to fire duplicate notification for same GFN on > x86 platform, with help of a hash table. This mechanism is going s/, with help of a hash table/this is achieved through a hash table > to be used by arm64 and this makes the code generic and shareable s/and this makes/.\n Turn the code generic > by multiple platforms. > > * As this mechanism isn't needed by all platforms, a new kernel > config option (CONFIG_ASYNC_PF_SLOT) is introduced so that it > can be disabled at compiling time. compile time > > * The code is basically copied from x86 platform and the functions > are renamed to reflect the fact: (a) the input parameters are > vCPU and GFN. not for reset (b) The operations are resetting, searching, adding > and removing. find, add, remove ops are renamed with _slot suffix > > * Helper stub is also added on !CONFIG_KVM_ASYNC_PF because we're > going to use IS_ENABLED() instead of #ifdef on arm64 when the > asynchronous page fault is supported. > > This is preparatory work to use the newly introduced functions on x86 > platform and arm64 in subsequent patches. > > Signed-off-by: Gavin Shan > --- > include/linux/kvm_host.h | 18 +++++++++ > virt/kvm/Kconfig | 3 ++ > virt/kvm/async_pf.c | 85 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 106 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index a5f990f6dc35..a9685c2b2250 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -298,6 +298,9 @@ struct kvm_vcpu { > > #ifdef CONFIG_KVM_ASYNC_PF > struct { > +#ifdef CONFIG_KVM_ASYNC_PF_SLOT > + gfn_t gfns[ASYNC_PF_PER_VCPU]; > +#endif > u32 queued; > struct list_head queue; > struct list_head done; > @@ -339,6 +342,13 @@ struct kvm_async_pf { > bool notpresent_injected; > }; > > +#ifdef CONFIG_KVM_ASYNC_PF_SLOT > +void kvm_async_pf_reset_slot(struct kvm_vcpu *vcpu); this does not reset a "slot" but the whole hash table. So to me this shouldn't be renamed with _slot suffix. reset_hash or reset_all_slots? > +void kvm_async_pf_add_slot(struct kvm_vcpu *vcpu, gfn_t gfn); > +void kvm_async_pf_remove_slot(struct kvm_vcpu *vcpu, gfn_t gfn); > +bool kvm_async_pf_find_slot(struct kvm_vcpu *vcpu, gfn_t gfn); > +#endif > + > static inline bool kvm_check_async_pf_completion_queue(struct kvm_vcpu *vcpu) > { > return !list_empty_careful(&vcpu->async_pf.done); > @@ -350,6 +360,14 @@ bool kvm_setup_async_pf(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa, > unsigned long hva, struct kvm_arch_async_pf *arch); > int kvm_async_pf_wakeup_all(struct kvm_vcpu *vcpu); > #else > +static inline void kvm_async_pf_reset_slot(struct kvm_vcpu *vcpu) { } > +static inline void kvm_async_pf_add_slot(struct kvm_vcpu *vcpu, gfn_t gfn) { } > +static inline void kvm_async_pf_remove_slot(struct kvm_vcpu *vcpu, gfn_t gfn) { } > +static inline bool kvm_async_pf_find_slot(struct kvm_vcpu *vcpu, gfn_t gfn) > +{ > + return false; > +} > + > static inline bool kvm_check_async_pf_completion_queue(struct kvm_vcpu *vcpu) > { > return false; > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > index 62b39149b8c8..59b518c8c205 100644 > --- a/virt/kvm/Kconfig > +++ b/virt/kvm/Kconfig > @@ -23,6 +23,9 @@ config KVM_MMIO > config KVM_ASYNC_PF > bool > > +config KVM_ASYNC_PF_SLOT > + bool > + > # Toggle to switch between direct notification and batch job > config KVM_ASYNC_PF_SYNC > bool > diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c > index d145a61a046a..0d1fdb2932af 100644 > --- a/virt/kvm/async_pf.c > +++ b/virt/kvm/async_pf.c > @@ -13,12 +13,97 @@ > #include > #include > #include > +#ifdef CONFIG_KVM_ASYNC_PF_SLOT > +#include > +#endif > > #include "async_pf.h" > #include > > static struct kmem_cache *async_pf_cache; > > +#ifdef CONFIG_KVM_ASYNC_PF_SLOT > +static inline u32 kvm_async_pf_hash(gfn_t gfn) > +{ > + BUILD_BUG_ON(!is_power_of_2(ASYNC_PF_PER_VCPU)); > + > + return hash_32(gfn & 0xffffffff, order_base_2(ASYNC_PF_PER_VCPU)); > +} > + > +static inline u32 kvm_async_pf_next_slot(u32 key) > +{ > + return (key + 1) & (ASYNC_PF_PER_VCPU - 1); > +} > + > +static u32 kvm_async_pf_slot(struct kvm_vcpu *vcpu, gfn_t gfn) > +{ > + u32 key = kvm_async_pf_hash(gfn); > + int i; > + > + for (i = 0; i < ASYNC_PF_PER_VCPU && > + (vcpu->async_pf.gfns[key] != gfn && > + vcpu->async_pf.gfns[key] != ~0); i++) > + key = kvm_async_pf_next_slot(key); > + > + return key; > +} > + > +void kvm_async_pf_reset_slot(struct kvm_vcpu *vcpu) > +{ > + int i; > + > + for (i = 0; i < ASYNC_PF_PER_VCPU; i++) > + vcpu->async_pf.gfns[i] = ~0; > +} > + > +void kvm_async_pf_add_slot(struct kvm_vcpu *vcpu, gfn_t gfn) > +{ > + u32 key = kvm_async_pf_hash(gfn); > + > + while (vcpu->async_pf.gfns[key] != ~0) > + key = kvm_async_pf_next_slot(key); > + > + vcpu->async_pf.gfns[key] = gfn; > +} > + > +void kvm_async_pf_remove_slot(struct kvm_vcpu *vcpu, gfn_t gfn) > +{ > + u32 i, j, k; > + > + i = j = kvm_async_pf_slot(vcpu, gfn); > + > + if (WARN_ON_ONCE(vcpu->async_pf.gfns[i] != gfn)) > + return; > + > + while (true) { > + vcpu->async_pf.gfns[i] = ~0; > + > + do { > + j = kvm_async_pf_next_slot(j); > + if (vcpu->async_pf.gfns[j] == ~0) > + return; > + > + k = kvm_async_pf_hash(vcpu->async_pf.gfns[j]); > + /* > + * k lies cyclically in ]i,j] > + * | i.k.j | > + * |....j i.k.| or |.k..j i...| > + */ > + } while ((i <= j) ? (i < k && k <= j) : (i < k || k <= j)); > + > + vcpu->async_pf.gfns[i] = vcpu->async_pf.gfns[j]; > + i = j; > + } > +} > + > +bool kvm_async_pf_find_slot(struct kvm_vcpu *vcpu, gfn_t gfn) > +{ > + u32 key = kvm_async_pf_slot(vcpu, gfn); > + > + return vcpu->async_pf.gfns[key] == gfn; > +} > +#endif /* CONFIG_KVM_ASYNC_PF_SLOT */ > + > int kvm_async_pf_init(void) > { > async_pf_cache = KMEM_CACHE(kvm_async_pf, 0); > Thanks Eric _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm