From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v8 1/9] KVM: arm/arm64: Ensure only THP is candidate for adjustment Date: Wed, 3 Oct 2018 11:50:38 +0100 Message-ID: <0809a9d0-d256-c23a-c3cc-0b2be33aecff@arm.com> References: <20181001155443.23032-1-punit.agrawal@arm.com> <20181001155443.23032-2-punit.agrawal@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181001155443.23032-2-punit.agrawal@arm.com> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Punit Agrawal , kvmarm@lists.cs.columbia.edu Cc: will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, Christoffer Dall , stable@vger.kernel.org List-Id: kvmarm@lists.cs.columbia.edu On 01/10/18 16:54, Punit Agrawal wrote: > PageTransCompoundMap() returns true for hugetlbfs and THP > hugepages. This behaviour incorrectly leads to stage 2 faults for > unsupported hugepage sizes (e.g., 64K hugepage with 4K pages) to be > treated as THP faults. > > Tighten the check to filter out hugetlbfs pages. This also leads to > consistently mapping all unsupported hugepage sizes as PTE level > entries at stage 2. > > Signed-off-by: Punit Agrawal > Reviewed-by: Suzuki Poulose > Cc: Christoffer Dall > Cc: Marc Zyngier > Cc: stable@vger.kernel.org # v4.13+ FWIW, I've cherry-picked that single patch from the series and queued it for 4.20. Thanks, M. -- Jazz is not dead. It just smells funny...