From: Marc Zyngier <maz@kernel.org>
To: Olof Johansson <olof@lixom.net>
Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm: Fix build after MMIO cleanup
Date: Tue, 21 Jan 2020 11:43:08 +0000 [thread overview]
Message-ID: <0e4e302783ffecf37eb809553f988625@kernel.org> (raw)
In-Reply-To: <20200121031007.106259-1-olof@lixom.net>
On 2020-01-21 03:10, Olof Johansson wrote:
> Looks like the mmio_decode field was accidentally left in on 32-bit:
>
> In file included from /build/include/linux/kvm_host.h:36,
> from /build/arch/arm/kernel/asm-offsets.c:15:
> arch/arm/include/asm/kvm_host.h:205:20: error: field 'mmio_decode' has
> incomplete type
>
> Fixes: 480bfa6478c8 ("KVM: arm/arm64: Cleanup MMIO handling")
> Cc: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> arch/arm/include/asm/kvm_host.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/include/asm/kvm_host.h
> b/arch/arm/include/asm/kvm_host.h
> index acf4c87e8321a..bd2233805d995 100644
> --- a/arch/arm/include/asm/kvm_host.h
> +++ b/arch/arm/include/asm/kvm_host.h
> @@ -201,9 +201,6 @@ struct kvm_vcpu_arch {
> /* Don't run the guest (internal implementation need) */
> bool pause;
>
> - /* IO related fields */
> - struct kvm_decode mmio_decode;
> -
> /* Cache some mmu pages needed inside spinlock regions */
> struct kvm_mmu_memory_cache mmu_page_cache;
Ouch. Thanks for that. I've squashed the fix in the original patch
(which I didn't really intend to be in -next just yet - not quite
sure what I did here).
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
prev parent reply other threads:[~2020-01-21 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 18:11 [PATCH] KVM: arm/arm64: Cleanup MMIO handling Marc Zyngier
2020-01-21 3:10 ` [PATCH] KVM: arm: Fix build after MMIO cleanup Olof Johansson
2020-01-21 11:43 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4e302783ffecf37eb809553f988625@kernel.org \
--to=maz@kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox