From: Eric Auger <eric.auger@linaro.org>
To: eric.auger@st.com, eric.auger@linaro.org, qemu-devel@nongnu.org,
pbonzini@redhat.com, peter.crosthwaite@xilinx.com
Cc: alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu,
patches@linaro.org
Subject: [PATCH 1/3] qdev: pass the check callback to qdev_init_gpio_out_named
Date: Tue, 28 Apr 2015 10:18:01 +0100 [thread overview]
Message-ID: <1430212683-10984-2-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1430212683-10984-1-git-send-email-eric.auger@linaro.org>
qdev_init_gpio_out_named takes a new argument corresponding to the
check callback passed to object_property_add_link. In qdev_init_gpio_out
this callback is set to the dummy object_property_allow_set_link.
This will allow qdev_init_gpio_out_named callers to specialize this
callback, typically sysbus.
Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
hw/core/qdev.c | 8 +++++---
include/hw/qdev-core.h | 3 ++-
include/qom/object.h | 3 +++
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 7fa58be..dc82df4 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -452,7 +452,8 @@ void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handler handler, int n)
}
void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins,
- const char *name, int n)
+ const char *name, int n,
+ object_property_set_link_t check_cb)
{
int i;
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
@@ -465,7 +466,7 @@ void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins,
memset(&pins[i], 0, sizeof(*pins));
object_property_add_link(OBJECT(dev), propname, TYPE_IRQ,
(Object **)&pins[i],
- object_property_allow_set_link,
+ check_cb,
OBJ_PROP_LINK_UNREF_ON_RELEASE,
&error_abort);
}
@@ -474,7 +475,8 @@ void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins,
void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pins, int n)
{
- qdev_init_gpio_out_named(dev, pins, NULL, n);
+ qdev_init_gpio_out_named(dev, pins, NULL, n,
+ object_property_allow_set_link);
}
qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 24c973d..9d500a3 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -294,7 +294,8 @@ void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pins, int n);
void qdev_init_gpio_in_named(DeviceState *dev, qemu_irq_handler handler,
const char *name, int n);
void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins,
- const char *name, int n);
+ const char *name, int n,
+ object_property_set_link_t fn);
void qdev_pass_gpios(DeviceState *dev, DeviceState *container,
const char *name);
diff --git a/include/qom/object.h b/include/qom/object.h
index d2d7748..4687fa1 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -33,6 +33,9 @@ typedef struct TypeInfo TypeInfo;
typedef struct InterfaceClass InterfaceClass;
typedef struct InterfaceInfo InterfaceInfo;
+typedef void (*object_property_set_link_t)(Object *, const char *,
+ Object *, Error **);
+
#define TYPE_OBJECT "object"
/**
--
1.8.3.2
next prev parent reply other threads:[~2015-04-28 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 9:18 [PATCH 0/3] Extend check callback usability for irq connect notifier Eric Auger
2015-04-28 9:18 ` Eric Auger [this message]
2015-04-28 9:18 ` [PATCH 2/3] qdev: check callback takes Object **target as third argument Eric Auger
2015-04-28 11:47 ` Paolo Bonzini
2015-04-28 9:18 ` [PATCH 3/3] sysbus: add irq_set_hook Eric Auger
2015-04-28 18:21 ` [PATCH 0/3] Extend check callback usability for irq connect notifier Peter Crosthwaite
2015-04-29 7:43 ` [Qemu-devel] " Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430212683-10984-2-git-send-email-eric.auger@linaro.org \
--to=eric.auger@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@st.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox