From: Alexander Graf <agraf@suse.de>
To: kvmarm@lists.cs.columbia.edu
Cc: Christoffer Dall <cdall@linaro.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH v2] KVM: arm/arm64: Handle hva aging while destroying the vm
Date: Wed, 5 Jul 2017 08:20:31 +0200 [thread overview]
Message-ID: <1499235631-141725-1-git-send-email-agraf@suse.de> (raw)
The kvm_age_hva callback may be called all the way concurrently while
kvm_mmu_notifier_release() is running.
The release function sets kvm->arch.pgd = NULL which the aging function
however implicitly relies on in stage2_get_pud(). That means they can
race and the aging function may dereference a NULL pgd pointer.
This patch adds a check for that case, so that we leave the aging
function silently.
Cc: stable@vger.kernel.org
Fixes: 293f29363 ("kvm-arm: Unmap shadow pagetables properly")
Signed-off-by: Alexander Graf <agraf@suse.de>
---
v1 -> v2:
- Fix commit message
- Add Fixes and stable tags
---
virt/kvm/arm/mmu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c
index f2d5b6c..227931f 100644
--- a/virt/kvm/arm/mmu.c
+++ b/virt/kvm/arm/mmu.c
@@ -861,6 +861,10 @@ static pud_t *stage2_get_pud(struct kvm *kvm, struct kvm_mmu_memory_cache *cache
pgd_t *pgd;
pud_t *pud;
+ /* Do we clash with kvm_free_stage2_pgd()? */
+ if (!kvm->arch.pgd)
+ return NULL;
+
pgd = kvm->arch.pgd + stage2_pgd_index(addr);
if (WARN_ON(stage2_pgd_none(*pgd))) {
if (!cache)
--
1.8.5.6
next reply other threads:[~2017-07-05 6:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 6:20 Alexander Graf [this message]
2017-07-05 6:27 ` [PATCH v2] KVM: arm/arm64: Handle hva aging while destroying the vm Christoffer Dall
2017-07-05 8:57 ` Suzuki K Poulose
2017-07-06 7:07 ` Alexander Graf
2017-07-06 7:45 ` Christoffer Dall
2017-07-06 9:31 ` Andrea Arcangeli
2017-07-06 9:43 ` Christoffer Dall
2017-07-06 9:34 ` Suzuki K Poulose
2017-07-06 9:42 ` Christoffer Dall
2017-07-14 16:40 ` Suzuki K Poulose
2017-07-16 19:56 ` Christoffer Dall
2017-07-17 13:03 ` Suzuki K Poulose
2017-07-17 14:45 ` Christoffer Dall
2017-07-17 15:16 ` Andrea Arcangeli
2017-07-17 18:23 ` Christoffer Dall
2017-07-17 20:49 ` Alexander Graf
2017-07-06 8:14 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499235631-141725-1-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=cdall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox