From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com,
cdall@linaro.org, peter.maydell@linaro.org,
andre.przywara@arm.com, wanghaibin.wang@huawei.com
Cc: wu.wubin@huawei.com
Subject: [PATCH v6 2/9] KVM: arm/arm64: vgic-its: Fix vgic_its_restore_collection_table returned value
Date: Thu, 26 Oct 2017 17:23:04 +0200 [thread overview]
Message-ID: <1509031391-4407-3-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1509031391-4407-1-git-send-email-eric.auger@redhat.com>
vgic_its_restore_cte returns +1 if the collection table entry
is valid and properly decoded. As a consequence, if the
collection table is fully filled with valid data that are
decoded without error, vgic_its_restore_collection_table()
returns +1. This is wrong.
Let's return 0 in that case.
Fixes: ea1ad53e1e31a3 (KVM: arm64: vgic-its: Collection table save/restore)
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
v5 -> v6:
- use the same trick as vgic_its_restore_itt and
vgic_its_restore_device_tables
v4 -> v5:
- added Christoffer R-b
v2 -> v3: creation
---
virt/kvm/arm/vgic/vgic-its.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
index d27a301..8230ffe 100644
--- a/virt/kvm/arm/vgic/vgic-its.c
+++ b/virt/kvm/arm/vgic/vgic-its.c
@@ -2268,6 +2268,10 @@ static int vgic_its_restore_collection_table(struct vgic_its *its)
gpa += cte_esz;
read += cte_esz;
}
+
+ if (ret > 0)
+ return 0;
+
return ret;
}
--
2.5.5
next prev parent reply other threads:[~2017-10-26 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 15:23 [PATCH v6 0/9] vITS Migration fixes and reset Eric Auger
2017-10-26 15:23 ` [PATCH v6 1/9] KVM: arm/arm64: vgic-its: Fix return value for device table restore Eric Auger
2017-10-26 15:23 ` Eric Auger [this message]
2017-11-02 5:50 ` [PATCH v6 2/9] KVM: arm/arm64: vgic-its: Fix vgic_its_restore_collection_table returned value Christoffer Dall
2017-10-26 15:23 ` [PATCH v6 3/9] KVM: arm/arm64: vgic-its: Check CBASER/BASER validity before enabling the ITS Eric Auger
2017-10-26 15:23 ` [PATCH v6 4/9] KVM: arm/arm64: vgic-its: Check GITS_BASER Valid bit before saving tables Eric Auger
2017-10-26 15:23 ` [PATCH v6 5/9] KVM: arm/arm64: vgic-its: Remove kvm_its_unmap_device Eric Auger
2017-10-30 2:49 ` Marc Zyngier
2017-10-26 15:23 ` [PATCH v6 6/9] KVM: arm/arm64: vgic-its: New helper functions to free the caches Eric Auger
2017-10-30 3:20 ` Marc Zyngier
2017-10-26 15:23 ` [PATCH v6 7/9] KVM: arm/arm64: vgic-its: Free caches when GITS_BASER Valid bit is cleared Eric Auger
2017-10-30 3:19 ` Marc Zyngier
2017-10-30 6:05 ` Christoffer Dall
2017-10-26 15:23 ` [PATCH v6 8/9] KVM: arm/arm64: Document KVM_DEV_ARM_ITS_CTRL_RESET Eric Auger
2017-10-30 3:21 ` Marc Zyngier
2017-10-30 6:06 ` Christoffer Dall
2017-10-26 15:23 ` [PATCH v6 9/9] KVM: arm/arm64: vgic-its: Implement KVM_DEV_ARM_ITS_CTRL_RESET Eric Auger
2017-10-30 3:22 ` Marc Zyngier
2017-10-30 6:11 ` Christoffer Dall
2017-10-30 6:20 ` [PATCH v6 0/9] vITS Migration fixes and reset Christoffer Dall
2017-10-30 7:59 ` Auger Eric
2017-10-31 6:43 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509031391-4407-3-git-send-email-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=andre.przywara@arm.com \
--cc=cdall@linaro.org \
--cc=eric.auger.pro@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
--cc=wanghaibin.wang@huawei.com \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox