From: Oliver Upton <oliver.upton@linux.dev>
To: Oliver Upton <oliver.upton@linux.dev>, kvmarm@lists.linux.dev
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Zenghui Yu <yuzenghui@huawei.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>, Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] KVM: arm64: Fix misuse of KVM_ARM_VCPU_POWER_OFF bit index
Date: Thu, 22 Jun 2023 17:17:44 +0000 [thread overview]
Message-ID: <168745425982.2113651.18159840293696452756.b4-ty@linux.dev> (raw)
In-Reply-To: <20230622160922.1925530-1-oliver.upton@linux.dev>
On Thu, 22 Jun 2023 16:09:22 +0000, Oliver Upton wrote:
> KVM_ARM_VCPU_POWER_OFF is as bit index, _not_ a literal bitmask.
> Nonetheless, commit e3c1c0cae31e ("KVM: arm64: Relax invariance
> of KVM_ARM_VCPU_POWER_OFF") started using it that way, meaning that
> powering off a vCPU with the KVM_ARM_VCPU_INIT ioctl is completely
> broken.
>
> Fix it by using a shifted bit for the bitwise operations instead.
>
> [...]
Applied, w/ Marc's suggestion to just use BIT() instead.
[1/1] KVM: arm64: Fix misuse of KVM_ARM_VCPU_POWER_OFF bit index
https://git.kernel.org/kvmarm/kvmarm/c/192df2aa0113
--
Best,
Oliver
prev parent reply other threads:[~2023-06-22 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 16:09 [PATCH] KVM: arm64: Fix misuse of KVM_ARM_VCPU_POWER_OFF bit index Oliver Upton
2023-06-22 16:14 ` Marc Zyngier
2023-06-22 17:17 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168745425982.2113651.18159840293696452756.b4-ty@linux.dev \
--to=oliver.upton@linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox