Linux KVM/arm64 development list
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
	kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 4/4] pre_init: add ARM implementations
Date: Wed, 2 Mar 2016 03:00:09 +0000	[thread overview]
Message-ID: <20160302030009.GB7637@arm.com> (raw)
In-Reply-To: <1456327988-31568-5-git-send-email-andre.przywara@arm.com>

On Wed, Feb 24, 2016 at 03:33:08PM +0000, Andre Przywara wrote:
> The pre_init stub consists of two syscalls mouting the host's FS
> via 9pfs and then calling the actual init binary, which can now
> use normal dynamic linking.
> Based on the x86 code provide an ARM and ARM64 implementation of
> that. Beside removing the need for static linkage it reduces the
> size of the kvmtool binary by quite a lot (numbers for aarch64):
> 
> -rwxr-xr-x 1 root root     9952 Nov 16 14:37 guest/init
> -rwxr-xr-x 1 root root      512 Nov 16 14:37 guest/pre_init
> -rwxr-xr-x 2 root root  1284704 Nov 16 14:37 lkvm
> vs. the old version:
> -rwxr-xr-x 1 root root   776024 Nov 16 14:38 guest/init
> -rwxr-xr-x 2 root root  2050112 Nov 16 14:38 lkvm
> 
> Tested on Midway and Juno.

Hmm, I'm not super keen on switching behaviour like this on arm, where
it's not uncommon to build a static lkvm and transfer it to a remote
target and expect init to work.

Perhaps we could only do this when building a dynamic executable?

Will

  reply	other threads:[~2016-03-02  3:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 15:33 [PATCH 0/4] kvmtool: add PRE_INIT support for ARM/ARM64 Andre Przywara
2016-02-24 15:33 ` [PATCH 1/4] pre_init: rename x86/init.S to x86/init64.S Andre Przywara
2016-02-24 15:33 ` [PATCH 2/4] pre_init: x86/init64.S: use defines for syscall numbers Andre Przywara
2016-02-24 15:33 ` [PATCH 3/4] pre_init: add support for i386 also Andre Przywara
2016-03-02  2:57   ` Will Deacon
2016-03-03 10:53     ` Andre Przywara
2016-02-24 15:33 ` [PATCH 4/4] pre_init: add ARM implementations Andre Przywara
2016-03-02  3:00   ` Will Deacon [this message]
2016-03-02 23:38     ` André Przywara
2016-03-03 21:08       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302030009.GB7637@arm.com \
    --to=will.deacon@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox