From: Christoffer Dall <christoffer.dall@linaro.org>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: marc.zyngier@arm.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] arm64: KVM: report configured SRE value to 32-bit world
Date: Wed, 17 Aug 2016 13:18:47 +0200 [thread overview]
Message-ID: <20160817111847.GH8808@cbox> (raw)
In-Reply-To: <57B44299.2000600@arm.com>
On Wed, Aug 17, 2016 at 11:55:21AM +0100, Vladimir Murzin wrote:
> On 17/08/16 11:46, Christoffer Dall wrote:
> > On Wed, Aug 10, 2016 at 10:49:43AM +0100, Vladimir Murzin wrote:
> >> After commit b34f2bc ("arm64: KVM: Make ICC_SRE_EL1 access return the
> >> configured SRE value") we report SRE value to 64-bit guest, but 32-bit
> >> one still handled as RAZ/WI what leads to funny promise we do not keep:
> >>
> >> "GICv3: GIC: unable to set SRE (disabled at EL2), panic ahead"
> >>
> >> We could keep that promise and force panic, but it doesn't look
> >> reliable, instead report configured SRE value to 32-bit guest.
> >
> > I don't really understand this part of the commit message?
> >
> > Why would we force a panic, and at what time?
>
> To make statement "panic ahead" true ;) kind of irony, so feel free to
> remove that part (alternatively I can re-spin v2)
>
No need, I just replaced it with:
Instead, return the actual value of the ICC_SRE_EL1 register that the
guest should see.
Thanks,
-Christoffer
prev parent reply other threads:[~2016-08-17 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 9:49 [PATCH] arm64: KVM: remove misleading comment on pmu status Vladimir Murzin
2016-08-10 9:49 ` [PATCH] arm64: KVM: report configured SRE value to 32-bit world Vladimir Murzin
2016-08-17 10:46 ` Christoffer Dall
2016-08-17 10:55 ` Vladimir Murzin
2016-08-17 11:18 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817111847.GH8808@cbox \
--to=christoffer.dall@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox