From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH 02/13] KVM: arm: fix gcc-4.5 build Date: Wed, 4 Jan 2017 11:38:33 +0100 Message-ID: <20170104103833.GB20461@cbox> References: <20161216105634.235457-1-arnd@arndb.de> <20161216105634.235457-3-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5444E405E9 for ; Wed, 4 Jan 2017 05:37:03 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vV+-asaHbWFN for ; Wed, 4 Jan 2017 05:37:00 -0500 (EST) Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 2D294400E9 for ; Wed, 4 Jan 2017 05:37:00 -0500 (EST) Received: by mail-lf0-f49.google.com with SMTP id k86so12700631lfi.0 for ; Wed, 04 Jan 2017 02:38:35 -0800 (PST) Content-Disposition: inline In-Reply-To: <20161216105634.235457-3-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org, kernel-build-reports@lists.linaro.org, linux-kernel@vger.kernel.org, Russell King , Andrew Morton , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@vger.kernel.org List-Id: kvmarm@lists.cs.columbia.edu On Fri, Dec 16, 2016 at 11:56:23AM +0100, Arnd Bergmann wrote: > Old gcc versions cannot used named initializers for anonymous > unions, leading to a build failure here. This replaces the anonymous > union with a named one, which allows us to build with at least gcc-4.3 > through 4.5. Versions 4.6 and higher are fine without this. > > virt/kvm/arm/vgic/vgic-mmio-v2.c:295: error: unknown field 'read' specified in initializer > virt/kvm/arm/vgic/vgic-mmio-v2.c:295: warning: missing braces around initializer > virt/kvm/arm/vgic/vgic-mmio-v2.c:295: warning: (near initialization for 'vgic_v2_dist_registers[0].') > virt/kvm/arm/vgic/vgic-mmio-v2.c:295: error: unknown field 'write' specified in initializer > virt/kvm/arm/vgic/vgic-mmio-v2.c:298: error: unknown field 'read' specified in initializer > > Fixes: 59c5ab40989a ("KVM: arm64: vgic-its: Introduce ITS emulation file with MMIO framework") > Signed-off-by: Arnd Bergmann If this series is moving ahead, I have no problems with this patch: Acked-by: Christoffer Dall