From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH v5 16/22] KVM: arm64: vgic-its: Add infrastructure for table lookup Date: Sun, 30 Apr 2017 13:13:38 -0700 Message-ID: <20170430201338.GC1670@lvm> References: <1492164934-988-1-git-send-email-eric.auger@redhat.com> <1492164934-988-17-git-send-email-eric.auger@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id ACC4740C44 for ; Sun, 30 Apr 2017 16:10:43 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3ZYJzCsncPra for ; Sun, 30 Apr 2017 16:10:42 -0400 (EDT) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 27B5740C2E for ; Sun, 30 Apr 2017 16:10:41 -0400 (EDT) Received: by mail-wm0-f52.google.com with SMTP id w64so77474541wma.0 for ; Sun, 30 Apr 2017 13:13:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1492164934-988-17-git-send-email-eric.auger@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Eric Auger Cc: kvm@vger.kernel.org, Prasun.Kapoor@cavium.com, marc.zyngier@arm.com, andre.przywara@arm.com, quintela@redhat.com, dgilbert@redhat.com, Vijaya.Kumar@cavium.com, vijayak@caviumnetworks.com, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, eric.auger.pro@gmail.com List-Id: kvmarm@lists.cs.columbia.edu On Fri, Apr 14, 2017 at 12:15:28PM +0200, Eric Auger wrote: > Add a generic lookup_table() helper whose role consists in > scanning a contiguous table located in guest RAM and applying > a callback on each entry. Entries can be handled as linked lists > since the callback may return an offset to the next entry and > also tell that an entry is the last one. > > Helper functions also are added to compute the device/event ID > offset to the next DTE/ITE. > > compute_next_devid_offset, compute_next_eventid_offset and > lookup_table will become static in subsequent patches > > Signed-off-by: Eric Auger > > --- > v4 -> v5: > - use kvm_read_guest > > v3 -> v4: > - remove static to avoid compilation warning > - correct size computation in looup_table() > - defines now encode the number of bits used for devid and eventid offsets > - use BIT() - 1 to encode the max offets > --- > virt/kvm/arm/vgic/vgic-its.c | 93 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 93 insertions(+) > > diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > index 56c5123..c22b35d 100644 > --- a/virt/kvm/arm/vgic/vgic-its.c > +++ b/virt/kvm/arm/vgic/vgic-its.c > @@ -195,6 +195,8 @@ static struct its_ite *find_ite(struct vgic_its *its, u32 device_id, > > #define VITS_TYPER_IDBITS 16 > #define VITS_TYPER_DEVBITS 16 > +#define VITS_DTE_MAX_DEVID_OFFSET (BIT(14) - 1) > +#define VITS_ITE_MAX_EVENTID_OFFSET (BIT(16) - 1) > > /* > * Finds and returns a collection in the ITS collection table. > @@ -1674,6 +1676,97 @@ int vgic_its_attr_regs_access(struct kvm_device *dev, > return ret; > } > > +u32 compute_next_devid_offset(struct list_head *h, struct its_device *dev) > +{ > + struct list_head *e = &dev->dev_list; > + struct its_device *next; > + u32 next_offset; > + > + if (e->next == h) > + return 0; > + next = list_entry(e->next, struct its_device, dev_list); > + next_offset = next->device_id - dev->device_id; > + > + return min_t(u32, next_offset, VITS_DTE_MAX_DEVID_OFFSET); > +} > + > +u32 compute_next_eventid_offset(struct list_head *h, struct its_ite *ite) > +{ > + struct list_head *e = &ite->ite_list; > + struct its_ite *next; > + u32 next_offset; > + > + if (e->next == h) > + return 0; > + next = list_entry(e->next, struct its_ite, ite_list); > + next_offset = next->event_id - ite->event_id; > + > + return min_t(u32, next_offset, VITS_ITE_MAX_EVENTID_OFFSET); nit: in both of these functions you can avoid the extra e variable and maybe make this slightly more readable by using these two calls instead: list_is_last(&ite->ite_list, h); next = list_next_entry(ite, ite_list); Thanks, -Christoffer